[#15207] - [4.0] Fix unit tests and runtime exception issue
- Fixed in Code Base
- 11 Apr 2017
- Medium
- Build: 4.0-dev
- # 15207
- Diff
- yvesh:fixruntime
User tests: Successful: Unsuccessful:
Summary of Changes
Fixes the unit tests in the 4.0-dev branch and an issue in the WebApplication class
Testing Instructions
Check if travis is green, test that everything is still working and do a code review
Expected result
RuntimeException is thrown
Actual result
Fatal error because runtime exception is not thrown
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries Unit Tests |
| Labels |
Added:
?
?
|
||
Unless you have an interface that you can rely on I don't understand why we wouldn't do subclass checks. Otherwise we have no clue what methods or properties actually do exist.
It's an arbitrary restriction. You assume if a factory method can build the object that's being returned, it meets at least whatever is in the doc block. We don't do these types of checks in any other factory we have. Why here?
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-04-11 16:40:20 |
| Closed_By | ⇒ | wilsonge |
Why are we testing that it is a subclass? I don't remember why I removed it in #12531 but it really seems fully unnecessary. There is also no other factory in our API which is doing this type of subclass or interface enforcement.