[#15200] - [hathor] com_banners client
- Closed
- 10 Apr 2017
- Medium
- Build: staging
- # 15200
- Diff
- brianteeman:hathor_banner_client
User tests: Successful: Unsuccessful:
Before this PR the client view will not work at all with the following error
Call to a member function get() on null
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Templates (admin) |
@franz-wohlkoenig with hathor?
I have tested this item
With testing date installed I get several errors.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15200.
@brianteeman yes, Hathor.
@brianteeman The issue you are fixing was fixed in this PR #15168 . Your propose fix also not a valid fix as it bypass the permission check.
So for this PR, please only keep the CS fix
and that is why it is essential to have pull requests with meaningful titles and descriptions. because you didnt you wasted my time and you wasted the time of people who are testing
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-04-10 11:09:30 |
| Closed_By | ⇒ | brianteeman | |
| Labels |
Added:
?
|
||
Without PR i don't get an Error looking at Banners-Client-List or Edit-View.