Feeling Lucky
?
[#15192] - Unreachable code
- Closed
- 11 Apr 2017
- Medium
- Build: staging
- # 15192
- Diff
- demis-palma:cleanup-2
User tests: Successful: Unsuccessful:
The second semicolon can't be reached, due to the return instruction.
To be merged on review.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | External Library Libraries |
brianteeman
- comment
- 10 Apr 2017
As a general rule we don't directly modify upstream llibraries. Not sure in this case as fof is now EOL
yasirunilan
- comment
- 11 Apr 2017
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15192.
| Status | Pending | ⇒ | Ready to Commit |
franz-wohlkoenig
- comment
- 11 Apr 2017
RTC after two successful tests.
zero-24
- comment
- 11 Apr 2017
We don't touch 3rd Party code even if there are EOL other example: PasswordHash #15191 (comment).
Closing as upstream issue.
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-04-11 17:49:38 |
| Closed_By | ⇒ | zero-24 | |
| Labels |
Added:
?
|
||
I have tested this item✅ successfully on 48dd6b2
Done code review.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15192.