New Feature PR-staging RTC

Pending

User tests: Successful: Unsuccessful:

avatar alikon
alikon
9 Apr 2017

Pull Request for Issue #14923 .

Summary of Changes

try to adress

  1. In the existing archived view being able to filter to a given category.

Testing Instructions

archivedcat

Expected result

able to filter archived article on categories too

Actual result

no option to filter on categories

avatar alikon alikon - open - 9 Apr 2017
avatar alikon alikon - change - 9 Apr 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 9 Apr 2017
Category Front End com_content
avatar franz-wohlkoenig franz-wohlkoenig - test_item - 9 Apr 2017 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 9 Apr 2017

I have tested this item successfully on f066c8b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15184.

avatar brianteeman
brianteeman - comment - 9 Apr 2017

I have restarted travis for this PR as the errors in travis were unrelated to the Pr

avatar franz-wohlkoenig franz-wohlkoenig - change - 9 Apr 2017
Easy No Yes
avatar joomla-cms-bot joomla-cms-bot - edited - 9 Apr 2017
avatar brianteeman
brianteeman - comment - 9 Apr 2017

To be consistent with other menu items I would move the new category selector to directly below the Menu Item Type field on the first tab

avatar alikon alikon - change - 10 Apr 2017
Labels Added: PR-staging
avatar alikon alikon - change - 10 Apr 2017
The description was changed
avatar alikon alikon - edited - 10 Apr 2017
avatar alikon
alikon - comment - 10 Apr 2017

moved to the 1st tab

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 10 Apr 2017 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 10 Apr 2017

I have tested this item successfully on 610ad34


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15184.

avatar waader waader - test_item - 10 Apr 2017 - Tested successfully
avatar waader
waader - comment - 10 Apr 2017

I have tested this item successfully on 051ca9b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15184.

avatar zero-24 zero-24 - change - 10 Apr 2017
Milestone Added: Joomla 3.7.0
Status Pending Ready to Commit
Labels Added: RTC
avatar zero-24
zero-24 - comment - 10 Apr 2017

RTC as the last commit was just a drone fix. Thanks!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15184.

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 10 Apr 2017 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 10 Apr 2017

I have tested this item successfully on 051ca9b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15184.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 10 Apr 2017

I have tested this item successfully on 051ca9b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15184.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 10 Apr 2017

RTC after two successful tests.

avatar Quy
Quy - comment - 10 Apr 2017

@franz-wohlkoenig Please remove RTC for now.

avatar rdeutz
rdeutz - comment - 10 Apr 2017

A while ago the same feature was discussed: #5810 :-)

avatar franz-wohlkoenig franz-wohlkoenig - change - 11 Apr 2017
Status Ready to Commit Pending
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 11 Apr 2017

Removed RTC as said by @Quy


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15184.

avatar alikon alikon - change - 11 Apr 2017
Labels Removed: RTC
avatar alikon
alikon - comment - 11 Apr 2017

@rdeutz
reason 2) from #5810 (comment)
is not so true as we have some use cases nowadays....

avatar rdeutz
rdeutz - comment - 11 Apr 2017

@alikon is wasn't true back these days anyway ;-)

avatar alikon
alikon - comment - 11 Apr 2017

@frankmayer is possible to set RTC again (cause last commit is only CS fix) so we can have another chance to be re-evaluated from mantainers ?

avatar rdeutz
rdeutz - comment - 11 Apr 2017

For me it looks good

avatar zero-24 zero-24 - change - 11 Apr 2017
Status Pending Ready to Commit
Labels Added: RTC
avatar wilsonge
wilsonge - comment - 11 Apr 2017

Given we are at RC status on 3.7 and this is a feature I'm moving it to the 3.8 milestone

avatar mbabker mbabker - change - 27 May 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-05-27 14:34:24
Closed_By mbabker
Labels Added: New Feature
avatar mbabker mbabker - close - 27 May 2017
avatar mbabker mbabker - merge - 27 May 2017
avatar csthomas
csthomas - comment - 2 Oct 2017

I added an issue related to this PR at #18186

Add a Comment

Login with GitHub to post a comment