Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#15178] - Implement stats debug modus using contstants

? ? Pending

User tests: Successful: Unsuccessful:

avatar zero-24
zero-24
8 Apr 2017

Pull Request for Issue #14634

Summary of Changes

implement debug modus using contstants cc @brianteeman It took longer that expected sorry for that :( see: #14634

Testing Instructions

  • apply this patch
  • confirm the GUI debug option is gone (Plugin settings advanced tab is gone)
  • go to the stats file
  • uncomment the line
  • confirm the method isDebugEnabled() return true.

Expected result

Works, without GUI option

Actual result

Works, just with the GUI option

Documentation Changes Required

None.

avatar zero-24 zero-24 - open - 8 Apr 2017
avatar zero-24 zero-24 - change - 8 Apr 2017
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 8 Apr 2017
Category ⇒ Front End Plugins
b27d349 8 Apr 2017 avatar zero-24 oops
avatar zero-24 zero-24 - change - 8 Apr 2017
Labels Added: ?
avatar Quy
Quy - comment - 8 Apr 2017

Remove the following language strings:
PLG_SYSTEM_STATS_DEBUG_LABEL
PLG_SYSTEM_STATS_DEBUG_DESC

avatar brianteeman
brianteeman - comment - 8 Apr 2017

@quy our standard practice is not to remove strings as they might be used by third parties etc

avatar joomla-cms-bot joomla-cms-bot - change - 8 Apr 2017
Category Front End Plugins ⇒ Administration Language & Strings Front End Plugins
avatar zero-24
zero-24 - comment - 8 Apr 2017

i have just added the deprecate comment to that strings ?

avatar Quy Quy - test_item - 9 Apr 2017 - Tested successfully
avatar Quy Quy - test_item - 9 Apr 2017 - Tested successfully
avatar Quy
Quy - comment - 9 Apr 2017

I have tested this item ✅ successfully on fab068c

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15178.

avatar rjcf18 rjcf18 - test_item - 14 Apr 2017 - Tested successfully
avatar rjcf18
rjcf18 - comment - 14 Apr 2017

I have tested this item ✅ successfully on fab068c

The GUI debug option is gone and the isDebugEnabled() method returns true.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15178.

avatar zero-24 zero-24 - change - 14 Apr 2017
Status Pending ⇒ Ready to Commit
avatar zero-24
zero-24 - comment - 14 Apr 2017

Thanks for the testers! RTC for 3.7.1

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15178.

avatar rdeutz rdeutz - change - 22 May 2017
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2017-05-22 19:04:12
Closed_By ⇒ rdeutz
Labels Added: ?
avatar rdeutz rdeutz - close - 22 May 2017
avatar rdeutz rdeutz - merge - 22 May 2017

Add a Comment

Login with GitHub to post a comment