[#15176] - [4.0] Change default controller to "controller". Redo #15075
- Fixed in Code Base
- 12 Apr 2017
- Medium
- Build: 4.0-dev
- # 15176
- Diff
- joomdonation:default-component-controller
User tests: Successful: Unsuccessful:
Pull Request for Issue #15041.
Summary of Changes
This is a redo of #15075 because I don't know how to resolve conflicts, sorry. There are some changes in this PR:
- Changes default component controller from COM_NAME to a generic controller name as discussed in #15041.
- Change code so that namespace stored in namespace column in database doesn't need to have backslash (Joomla\Component\Content instead of Joomla\Component\Content\ ).
- Build basic controller config data keys like option and name so that controller class doesn't have to guess these from class name
- Add class_exists check to controller class to avoid fatal error
- Small update to docblock
Testing Instructions
Code review by Joomla 4 team only.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Title |
|
||||||
| Labels |
Added:
?
|
||
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-04-12 12:11:07 |
| Closed_By | ⇒ | wilsonge |
@joomdonation just noticed, shouldn't we use addPsr4 instead of setPsr4? set overrides, add adds :)
No because otherwise when you create a second dispatcher instance (e.g. in a second module you are going to end up adding the same path multiple times no?
Set overrides, is there any reason we would like to do that?
Is it a problem to only have a single prefix per component?
In theory someone could still manipulate the class loader to put their custom paths before the core paths (same way you can now if you know what you're doing with JControllerLegacy, JModelLegacy, and JTable). So I think we'd want to use the adder over the setter.
With the reason explains by Michael, I agree that using addPsr4 would be better (at least in theory). When a dispatcher is created a second time for example, yes, the same paths will be added again but it doesn't cost much (just two new elements added to the paths array)
However, with the RFC #15226 by Allon (which looks like I agree), we won't need autoLoad method in dispatcher anymore.
With that said, I will leave it as how it is for now and in case #15226, we will make this change
@joomdonation can you edit the com_content namespace files as appropriate for this change please