[#15174] - [4.0] View classes improvements. Redo #14721
- Fixed in Code Base
- 8 Apr 2017
- Medium
- Build: 4.0-dev
- # 15174
- Diff
- joomdonation:mvc-view-retry
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
This is a redo of #14721 because I could not resolve conflicts. Below are the changes:
Below are the list of changes/improvements:
-
Split original View class into AbstractView and HtmlView classes. The purpose is supporting more format like Rss, Json, Csv... in the future.
-
Introduce FormView to handle form add/edit item in the backend. Many repeating/ boring code like getting data, addToolbar can be automatically with this class. See https://github.com/joomdonation/joomla-cms/blob/namespace-banners/administrator/components/com_banners/View/Banner/Html.php for a sample usage
-
Introduce ListView to handle displaying list of items in the backend. Same with FormView, repeating code is moved into this class so that child class won't have to implement these stuff. See https://github.com/joomdonation/joomla-cms/blob/namespace-banners/administrator/components/com_banners/View/Banners/Html.php for a real usage.
Testing instructions:
At the moment, this is open for discussion / review only and waiting for decision for Joomla 4 team.
Documentation Changes Required
Document how to use FormView and ListView classes
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Title |
|
||||||
Couple of small comments. But looks like a massive improvement :) Really nice work!
Sorry, my comments above need to be in reserved. Windows is case-insensitive and Linux is case-sensitive, too late here
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-04-08 20:40:36 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
I'm good with this. We need to have a think about this view vs View thing. But I think this is a great start. Thankyou so much @joomdonation
CS and unit tests fails are not related to this PR.