? Pending

User tests: Successful: Unsuccessful:

avatar astridx
astridx
7 Apr 2017

Pull Request for Issue # #15159
#15159

Summary of Changes

I changed only two wrong language strings

avatar astridx astridx - open - 7 Apr 2017
avatar astridx astridx - change - 7 Apr 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 7 Apr 2017
Category Front End Plugins
avatar brianteeman brianteeman - test_item - 7 Apr 2017 - Tested successfully
avatar brianteeman
brianteeman - comment - 7 Apr 2017

I have tested this item successfully on f068fd3


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15164.

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 8 Apr 2017 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 8 Apr 2017

I have tested this item successfully on f068fd3

After PR "Select some Options" is shown.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15164.

avatar franz-wohlkoenig franz-wohlkoenig - change - 8 Apr 2017
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 8 Apr 2017

RTC after two successful tests.

avatar AlexRed
AlexRed - comment - 8 Apr 2017

sorry but I don't understand. Why a parameter to "Hide Buttons" when no plugin Buttons are show in the editor Field by default ?

avatar astridx
astridx - comment - 8 Apr 2017

@AlexRed
In my installation per default all buttons are shown. And with this option I can hide special buttons for the field.

avatar AlexRed
AlexRed - comment - 8 Apr 2017

In Joomla! 3.7.0-RC1 and in the stagin not buttons are shown per default for me
no-plugin-editor

avatar AlexRed
AlexRed - comment - 8 Apr 2017

non sense use the "read more" (or page break) in a editor in the contact mail form or user registration form. Better a parameter to include single editor plugin.

avatar AlexRed
AlexRed - comment - 8 Apr 2017

sorry... my error, I don't see the "Show Buttons" :(
maybe the " Hide Buttons" parameter need to be visible only if the "Show Buttons" is set to yes

avatar infograf768
infograf768 - comment - 8 Apr 2017

non sense use the "read more" in a editor in the contact mail form

That one is weird indeed as other editors-xtd will not show even if none is set to hide and Show Buttons is set to Yes.
@laoneo Can you look into that precise aspect?

avatar infograf768
infograf768 - comment - 8 Apr 2017

I suggest to improve the editor xml field by adding
showon="buttons:1" in the hide field in both editor.xml

Can't make PR now as this PR has first to be merged, or the showon added here.

avatar astridx
astridx - comment - 8 Apr 2017

@infograf768
I want to do your suggestion. But I wonder how we can handle the "show global" or "use from plugin" option?

avatar infograf768
infograf768 - comment - 8 Apr 2017

@astridx
showon="buttons:1" will display the hide field ONLY when buttons are set to Yes (value=1).
If one choses Use from Plugin, we shall not and cannot Hide anything for the field itself as the settings comes from the plugin settings.

In the case of the plugin settings, If Show Buttons is set to No, then no need to use the Hide field.

Does this clarifies?

avatar infograf768
infograf768 - comment - 8 Apr 2017

Just spoke with @Bakual and tested:
In fact Use from Plugin does not even work here, which means that we do have a bug.

avatar infograf768 infograf768 - change - 8 Apr 2017
Milestone Added:
avatar infograf768
infograf768 - comment - 8 Apr 2017

GRRR.... Issues.joomla.org playing on me...

This is RTC and for 3.7.0

Let's discuss elsewhere of the showin and Use Plugin Param.

avatar Bakual Bakual - change - 8 Apr 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-04-08 17:30:14
Closed_By Bakual
Labels Added: ?
avatar Bakual Bakual - close - 8 Apr 2017
avatar Bakual Bakual - merge - 8 Apr 2017

Add a Comment

Login with GitHub to post a comment