Feeling Lucky
?
[#1514] - [#31144] Added options to include/exclude menu items or components from caching
- Closed
- 14 Mar 2015
- Medium
- Build: master
- # 1514
- Diff
- laoneo:cache
- Foreign ID 31144
- Error default This pull request is targeted at the master branch. Pull requests should no longer be merged to master. Details
User tests: Successful: Unsuccessful:
| Labels |
Added:
?
|
||
| Status | New | ⇒ | Pending |
nicksavov
- | Labels |
Removed:
?
|
||
dbhurley
- | Labels |
Added:
?
|
||
| Labels |
Removed:
?
|
||
| Title |
|
||||||
Hackwar
- comment
- 5 Feb 2015
In any case, if you want to have this still in Joomla, please create a new PR against staging and resolve the merge conflicts.
vdespa
- comment
- 14 Mar 2015
After considerable time without update I am marking this issue as "Closed".
See also @Hackwar comment. Thanks for your work!
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/1514.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-03-14 13:19:36 |
| Closed_By | ⇒ | brianteeman |
| Closed_Date | 2015-03-14 13:19:36 | ⇒ | 2015-03-14 13:19:37 |
laoneo
- comment
- 16 Mar 2015
Great, spending hours to get it done and then it will be thrown away!
brianteeman
- comment
- 16 Mar 2015
If you do what was requested last month then it can be reopened. But sadly as it is right now it cant even be tested
I disagree with this PR. I think including the whole menu system already and doing all the routing is already to much work before the caching takes effect. I would not complicate this further. Rather, an extension should be able to prevent the caching from the outside. That however is something that already requires so much logic all over the system, that someone should rather use the normal caching than the page cache.