[#15129] - Add IE11+ and Edge browser matching
- Fixed in Code Base
- 7 Apr 2017
- Medium
- Build: staging
- # 15129
- Diff
- bembelimen:Browser_Check
User tests: Successful: Unsuccessful:
Summary of Changes
At the moment IE11+ and Edge will not recognized correctly, because Microsoft delivers "strange" user agents (see: https://msdn.microsoft.com/en-us/library/ms537503(v=vs.85).aspx)
With this fix, Edge and IE11 will be regognized correctly
Testing Instructions
The most common case, where a browser check will be used is while loading CSS/JS files.
So go to libraries/cms/html/html.php line 334 and add print_r($potential);
else
{
$potential = array($strip);
}
print_r($potential);
// If relative search in template directory or media directory
if ($relative)
{
If you go to your Joomla! page, you'll see that Joomla! tries to load different browser dependend CSS/JS files with the format filename_browsername_majorversion_minorversion (i.e. mozilla_5_0).
Expected result
If you browse with IE11 or Edge, Joomla! should recognize this browsers
Actual result
IE11 will be recognized as Mozilla, Edge as Chrome.
Now apply patch and the correct versions should be displayed.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Labels |
Added:
?
|
||
@bembelimen IMHO it should be edge not msie.
Then the PR is correct ;)
I've tested this successfully on 3.7 beta4
I've tested this successfully on 3.7.0-rc1
| Status | Pending | ⇒ | Ready to Commit |
RTC after two successful testes.
wilsonge
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-04-07 20:07:09 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
The question here is: should "Edge" be recognized as "edge" or as "msie"?