Feeling Lucky
?
?
[#15125] - Fix typo in Hathor template name
- Closed
- 6 Apr 2017
- Medium
- Build: staging
- # 15125
- Diff
- joomla:Bakual-patch-1
- Pending continuous-integration/travis-ci/push The Travis CI build is in progress Details
- Pending continuous-integration/appveyor/branch Waiting for AppVeyor build to complete Details
- Success continuous-integration/drone/push the build was successful Details
- Pending continuous-integration/drone/pr this build is pending Details
User tests: Successful: Unsuccessful:
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_admin Language & Strings |
| Title |
|
||||||
alikon
- comment
- 6 Apr 2017
I have tested this item
on review
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15125.
joomdonation
- comment
- 6 Apr 2017
There is another typo here https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_admin/script.php#L122 which need to be fixed, too
That line need to be changed to ->where($db->quoteName('template') . ' = "hathor"')
infograf768
- comment
- 6 Apr 2017
Agree with @joomdonation and @Bakual
rdeutz
- comment
- 6 Apr 2017
I have fixed the typos
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-04-06 06:52:10 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
?
|
||
That being said, the file
administrator/language/en-GB/en-GB.lib_joomla.iniis the wrong place for such a warning message. That file needs to be in sync with frontend and we certainly don't need that message in frontend. I left it for now since this PR is about fixing the typos.