[#15115] - Fix grammar
- Fixed in Code Base
- 5 Apr 2017
- Medium
- Build: staging
- # 15115
- Diff
- Quy:patch-6
User tests: Successful: Unsuccessful:
Summary of Changes
Change it's to its.
Testing Instructions
Code review.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_fields |
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-04-05 18:47:27 |
| Closed_By | ⇒ | zero-24 | |
| Labels |
Added:
?
|
||
Just curious, what does it mean in the Joomla land when somebody is approving a pr?
Someone basically did a code review but didn't really test it is the way I read it.
How can you test a comment change?
Exactly
My question (not critic) was in general and not particular for this pr. I see more and more people approving pull requests but not testing them.
Several months ago on glip it was suggested that all PR needed to be tested and to have reviews
@laoneo - Personally, I tend to do this when I don't have time to test a smaller PR properly, but instead have a quick skim through the code.
On PR's like this where a single word is corrected, whether it's a test from JIssues or a GitHub approval, doesn't really make any difference. You're just approving the change.
Thanks