? Pending

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
4 Apr 2017

Pull Request for Issue #15063

Summary of Changes

Changing " to htmlentity " in the jhtml

Testing Instructions

See #15063

Expected result

Works after patch.

finder-filters

@Quy @dgt41 @franz-wohlkoenig

avatar infograf768 infograf768 - open - 4 Apr 2017
avatar infograf768 infograf768 - change - 4 Apr 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 4 Apr 2017
Category Front End com_finder
avatar brianteeman brianteeman - test_item - 4 Apr 2017 - Tested successfully
avatar brianteeman
brianteeman - comment - 4 Apr 2017

I have tested this item successfully on 75c550d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15092.

avatar afk afk - test_item - 4 Apr 2017 - Tested successfully
avatar afk
afk - comment - 4 Apr 2017

I have tested this item successfully on 75c550d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15092.

avatar franz-wohlkoenig franz-wohlkoenig - change - 4 Apr 2017
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 4 Apr 2017

RTC after two successful testes.

avatar Quy
Quy - comment - 4 Apr 2017

You may want to combine the 2 class attributes in the main Toggle Selection button in this PR.
<button class="btn btn-default" type="button" class="jform-rightbtn" onclick="jQuery('.filter-node').each(function () { this.click(); });">

avatar afk
afk - comment - 4 Apr 2017

The PR combines it to class="btn jform-rightbtn".

avatar Quy
Quy - comment - 4 Apr 2017

Yes, but there is a main Toggle Selection button to toggle all checkboxes and not within each section.

avatar C-Lodder
C-Lodder - comment - 4 Apr 2017

Please could you remove the class jform-rightbtn as this isn't needed.

avatar rdeutz rdeutz - change - 4 Apr 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-04-04 19:10:51
Closed_By rdeutz
Labels Added: ?
avatar rdeutz rdeutz - close - 4 Apr 2017
avatar rdeutz rdeutz - merge - 4 Apr 2017
avatar infograf768
infograf768 - comment - 5 Apr 2017

@C-Lodder

Please could you also remove the class jform-rightbtn, as this isn't needed.

It is used by Hathor.

@Quy
You are right, the classes should be also be combined in
/administrator/components/com_finder/views/filter/tmpl/edit.php line 73.
Please make PR.

avatar C-Lodder
C-Lodder - comment - 5 Apr 2017

@infograf768 Hathor already contains a float classes. So, fltrt can just be used and the jform-rightbtn class can be removed

avatar infograf768
infograf768 - comment - 5 Apr 2017

@C-Lodder
Please post here #15097 to improve at the same time.

I done my part ?

avatar Quy
Quy - comment - 24 May 2017

@C-Lodder jform-rightbtn is in \administrator\templates\hathor\less\template.less . Should it still be replaced with fltrt?

Add a Comment

Login with GitHub to post a comment