Feeling Lucky
?
[#15081] - Change namespace from cms to CMS
- Fixed in Code Base
- 3 Apr 2017
- Medium
- Build: 3.8-dev
- # 15081
- Diff
- brianteeman:3.8-dev
User tests: Successful: Unsuccessful:
Pull Request for Issue #15072 .
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
wilsonge
- comment
- 3 Apr 2017
I think you did the wrong folder. I think you wanted to make libraries/src/Joomla/CMS uppercase not the old libraries/cms that contains the non-namespaced code in :)
brianteeman
- comment
- 3 Apr 2017
grrh - blame Dmitri for that
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-04-03 23:03:34 |
| Closed_By | ⇒ | brianteeman | |
| Labels |
Added:
?
|
||
zero-24
- comment
- 3 Apr 2017
Did you realy want to merge it in this state?
brianteeman
- comment
- 3 Apr 2017
no - it was a mistake - can you revert it please
zero-24
- comment
- 3 Apr 2017
I'm on my phone and cant see a revert button. If you can see it just hit them ;)
brianteeman
- comment
- 3 Apr 2017
PS the branch with the correct PR is https://github.com/brianteeman/joomla-cms/tree/namespace-3.8
brianteeman
- comment
- 3 Apr 2017
actually looked like the code I merged by accident is correct so I will leave it to you to decide to undo it or not
Looks like travis didnt like the folder being renamed