Feeling Lucky
?
?
[#15075] - [4.0] Namespace - Change default controller
- Closed
- 8 Apr 2017
- Medium
- Build: 4.0-dev
- # 15075
- Diff
- joomdonation:patch-3
User tests: Successful: Unsuccessful:
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Labels |
Added:
?
|
||
RonakParmar
- comment
- 5 Apr 2017
I have tested this item
Done code review.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15075.
| Category | Libraries | ⇒ | Libraries Unit Tests |
joomdonation
- comment
- 7 Apr 2017
So I made further change beside to just changes default controller name;
- Change Controller to BaseController. It will allows us to write shorter code in default component controller
use Joomla\Cms\BaseController;
class Controller extends BaseController;
Instead of
use Joomla\Cms\Controller as CmsController;
class Controller extends CmsController;
- Passing option and name to controller config array. That save controller not having to detect dynamic these information from class name.
joomdonation
- comment
- 8 Apr 2017
Again, close because I could not resolve conflicts :(
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-04-08 10:07:44 |
| Closed_By | ⇒ | joomdonation | |
| Labels |
Added:
?
|
||
While looking at this, I also have some questions:
With the current implement, the data stored in namespace column must contain backslash Joomla\Component\Content\ . I think without backlash Joomla\Component\Content might be better
Do we really want to introduce a new way to pass controller name via controller variable in the request? At least for current usage, the widely use task=controller.method is good enough.