Maybe its just me but everytime i see something like
\\Joomla\\Cms\\Helper\\AuthenticationHelper',
I want to scream USE UPPERCASE
Use all capitals if an abbreviation is pronounced as the individual letters (an initialism): HTML, CSS
| Labels |
Added:
?
|
||
So can we change it then to CMS ??
Now is the time to get it right - we wont be able to change it later (I think)
| Category | ⇒ | Code style |
| Priority | Medium | ⇒ | Low |
| Status | New | ⇒ | Discussion |
If its ok to change to CMS I am happy to make the changes
I'm good with it personally. Just know you'd need to fix the casing in the filesystem too and that always gets a little tricky (luckily we aren't dealing with anything that's been released yet).
so you are or are not in favour of me spending the time to address this.
I am in favor.
OK - will close this and will try to work on a PR for 3.8 branch I assume and I need to find where in the filesytem it is defined
| Status | Discussion | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-04-03 21:47:59 |
| Closed_By | ⇒ | brianteeman |
@brianteeman it's the first folder in libraries: https://github.com/joomla/joomla-cms/tree/staging/libraries
yeah - got it - just doing the rename in git
how about dropping the Cms or CMS in favour of Core? It makes more sense to me
Nope, not just you. Personal preference with namespaced code is to use uppercase for acronyms unless there's a technical reason not to. Composer's autoloader doesn't have that reason, I sure hope JLoader doesn't too.