?
avatar brianteeman
brianteeman
3 Apr 2017

Maybe its just me but everytime i see something like
\\Joomla\\Cms\\Helper\\AuthenticationHelper',

I want to scream USE UPPERCASE
Use all capitals if an abbreviation is pronounced as the individual letters (an initialism): HTML, CSS

avatar brianteeman brianteeman - open - 3 Apr 2017
avatar joomla-cms-bot joomla-cms-bot - change - 3 Apr 2017
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 3 Apr 2017
avatar mbabker
mbabker - comment - 3 Apr 2017

Nope, not just you. Personal preference with namespaced code is to use uppercase for acronyms unless there's a technical reason not to. Composer's autoloader doesn't have that reason, I sure hope JLoader doesn't too.

avatar brianteeman
brianteeman - comment - 3 Apr 2017

So can we change it then to CMS ??

Now is the time to get it right - we wont be able to change it later (I think)

avatar franz-wohlkoenig franz-wohlkoenig - change - 3 Apr 2017
Category Code style
avatar franz-wohlkoenig franz-wohlkoenig - change - 3 Apr 2017
Priority Medium Low
Status New Discussion
avatar brianteeman
brianteeman - comment - 3 Apr 2017

If its ok to change to CMS I am happy to make the changes

avatar mbabker
mbabker - comment - 3 Apr 2017

I'm good with it personally. Just know you'd need to fix the casing in the filesystem too and that always gets a little tricky (luckily we aren't dealing with anything that's been released yet).

avatar brianteeman
brianteeman - comment - 3 Apr 2017

so you are or are not in favour of me spending the time to address this.

avatar mbabker
mbabker - comment - 3 Apr 2017

I am in favor.

avatar brianteeman
brianteeman - comment - 3 Apr 2017

OK - will close this and will try to work on a PR for 3.8 branch I assume and I need to find where in the filesytem it is defined

avatar brianteeman brianteeman - change - 3 Apr 2017
Status Discussion Closed
Closed_Date 0000-00-00 00:00:00 2017-04-03 21:47:59
Closed_By brianteeman
avatar brianteeman brianteeman - close - 3 Apr 2017
avatar dgt41
dgt41 - comment - 3 Apr 2017
avatar brianteeman
brianteeman - comment - 3 Apr 2017

yeah - got it - just doing the rename in git

avatar brianteeman
brianteeman - comment - 3 Apr 2017

OK gave it a go see #15081

avatar dgt41
dgt41 - comment - 3 Apr 2017

how about dropping the Cms or CMS in favour of Core? It makes more sense to me

Add a Comment

Login with GitHub to post a comment