@brianteeman hathor maybe?

@dgt41 nope hathor has its own override
joomla-cms/administrator/templates/hathor/html/layouts/com_messages/toolbar/mysettings.php

@dgt41 from what i can see your pr for some reason (perhaps by accident) reverted the earlier pr that added the layout

nope, the code is correct, we don't need the extra layout file just for the toolbar button (with the modal) we are doing that in the main layout (and the button in the html) as the rest of the jooma stuff

wondering why it was put in the first place then, later removed by you but
not removed from the core files

http://www.avg.com/email-signature?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail
Virus-free.
www.avg.com
http://www.avg.com/email-signature?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail
<#DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2>

On 2 April 2017 at 22:34, Dimitri Grammatikogianni <notifications@github.com

wrote:

nope, the code is correct, we don't need the extra layout file just for
the toolbar button (with the modal) we are doing that in the main layout
(and the button in the html) as the rest of the jooma stuff

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#15064 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8auIhNEJvbr6Pmjqjj8yGVo9e2Ssks5rsBRUgaJpZM4Mw7_w
.

--
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
https://brian.teeman.net/ http://brian.teeman.net/

The first time around was needed (mootools modal). My code just refactor this part to use the Bootstrap Modal, so probably you could blame me for leaving that useless code there...

The original purpose was to kill off the remaining hardcoded markup for toolbar buttons. As long that isn't lost then we're good.

Ok. In the morning i will do a pr to remove this unused file and check the other component specific layouts to see if any others are redundant and should be removed.

That button now uses the popup with a url for the iframe so there is no html fragment heeded there. Maybe we should review the popup creator but that's another scope

@brianteeman maybe the batch parts are also candidates...

I am not refactoring only looking at unused stuff :)

Closed see #15065