Joomla! Issue Tracker | Joomla! CMS #15047 - [a11y] [com

Fixed in Code Base
29 May 2017
Medium
Build: staging
# 15047
Diff
brianteeman:a11y_modal

Pending

User tests: Successful: Unsuccessful:

brianteeman
1 Apr 2017

Continuing the work to ensure that screen readers dont try to read the value of a font icon.

This PR could be improved with the use of titles as well if anyone has some suggestions to get the requires strings

f1c7cca 1 Apr 2017

[a11y] icons in modals

brianteeman - open - 1 Apr 2017

brianteeman - change - 1 Apr 2017

Status

New

⇒

Pending

joomla-cms-bot - change - 1 Apr 2017

Category

Administration com_associations com_categories com_contact com_content com_fields com_modules com_newsfeeds

⇒

Accessibility Administration com_associations com_categories com_contact com_content com_fields com_modules com_newsfeeds

franz-wohlkoenig - change - 7 Apr 2017

Title

…

[a11y] icons in modals

[a11y] [com_fields] icons in modals

joomla-cms-bot - edited - 7 Apr 2017

tonypartridge - comment - 23 May 2017

I have tested this item ✅ successfully on 96e1575

Code review.

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15047.}

tonypartridge - test_item - 23 May 2017 - Tested successfully

Quy - comment - 24 May 2017

Here is an idea to get the status strings:

				<?php
				$iconStates = array(
					-2 => array('icon-trash', JText::_('JTRASHED')),
					0 => array('icon-unpublish', JText::_('JUNPUBLISHED')),
					1 => array('icon-publish', JText::_('JPUBLISHED')),
					2 => array('icon-archive', JText::_('JARCHIVED')),
				);
				?>

						<td class="center">
							<span class="<?php echo $iconStates[$this->escape($item->state)][0]; ?>" aria-hidden="true"></span> <span class="element-invisible"><?php echo $iconStates[$this->escape($item->state)][1]; ?></span>
						</td>

63d287f 24 May 2017

Update modal.php

5b2b30a 24 May 2017

changes

brianteeman - comment - 24 May 2017

typos fixed - thanks
@Quy I will leave that suggestion for another PR

Quy - comment - 24 May 2017

I have tested this item ✅ successfully on 5b2b30a

Code review.

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15047.}

Quy - test_item - 24 May 2017 - Tested successfully

franz-wohlkoenig - comment - 24 May 2017

@tonypartridge can you please retest?