? Failure

User tests: Successful: Unsuccessful:

avatar NunoLopes96
NunoLopes96
1 Apr 2017

Pull Request for Issue # .

Summary of Changes

Remove an attribute that was causing a bug when typing password on installation

Testing Instructions

Write till 3 characters on the password filed

Expected result

No "empty" message

Actual result

Actually this is showing that the field is empty when its not

avatar NunoLopes96 NunoLopes96 - open - 1 Apr 2017
avatar NunoLopes96 NunoLopes96 - change - 1 Apr 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 1 Apr 2017
Category Repository Unit Tests JavaScript Administration com_admin SQL Postgresql MS SQL
avatar jreys
jreys - comment - 1 Apr 2017

Instead of removing the message you should actually change the old one to something like "Field value is too short"

avatar franz-wohlkoenig franz-wohlkoenig - change - 1 Apr 2017
Priority Medium Low
avatar C-Lodder
C-Lodder - comment - 1 Apr 2017

Could you please add [4.0] to the title of the PR, so people can easily see which branch it's for

avatar brianteeman brianteeman - change - 1 Apr 2017
Title
Installation password bug
[4.0]Installation password bug
avatar brianteeman brianteeman - change - 1 Apr 2017
Title
Installation password bug
[4.0]Installation password bug
avatar brianteeman brianteeman - edited - 1 Apr 2017
avatar joomla-cms-bot joomla-cms-bot - change - 1 Apr 2017
Category Repository Unit Tests JavaScript Administration com_admin SQL Postgresql MS SQL Installation
avatar brianteeman
brianteeman - comment - 1 Apr 2017

Updated title as requested

avatar franz-wohlkoenig franz-wohlkoenig - change - 1 Apr 2017
Category Installation Administration com_admin JavaScript MS SQL Postgresql Repository SQL Unit Tests
avatar joomla-cms-bot joomla-cms-bot - change - 1 Apr 2017
Title
[4.0]Installation password bug
[4.0 ]Installation password bug
avatar franz-wohlkoenig franz-wohlkoenig - change - 1 Apr 2017
Title
[4.0]Installation password bug
[4.0 ]Installation password bug
avatar joomla-cms-bot joomla-cms-bot - change - 1 Apr 2017
Category Administration com_admin JavaScript MS SQL Postgresql Repository SQL Unit Tests Installation
avatar joomla-cms-bot joomla-cms-bot - edited - 1 Apr 2017
avatar franz-wohlkoenig franz-wohlkoenig - change - 1 Apr 2017
Easy No Yes
avatar NunoLopes96
NunoLopes96 - comment - 2 Apr 2017

I think this is showing All checks failed because by mistake I made this PR to staging branch and then changed to the current one (4.0-dev), no?

avatar dgt41
dgt41 - comment - 8 Apr 2017

@NunoLopes96 this is not the right approach, please don't merge this!!!

avatar brianteeman brianteeman - change - 8 Jun 2017
Milestone Added:
avatar brianteeman brianteeman - change - 8 Jun 2017
Milestone Added:
avatar brianteeman brianteeman - change - 27 Jul 2017
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2017-07-27 21:24:21
Closed_By brianteeman
Labels Added: ?
avatar brianteeman brianteeman - close - 27 Jul 2017
avatar brianteeman
brianteeman - comment - 27 Jul 2017

I am closing this as it is clearly not correct

Add a Comment

Login with GitHub to post a comment