Language Change RTC

Pending

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
31 Mar 2017

Summary of Changes

Improving TinyMCE warning when updating to 3.7.0

Testing Instructions

Update a 3.6.5 to staging.

Modifying from
The <a href="_QQ_"%s"_QQ_">TinyMCE Editor Plugin</a> has been updated. Currently it uses your existing configuration. By editing the plugin, you can now assign and customise various layouts to specific user groups.
to
The <a href="_QQ_"%s"_QQ_">TinyMCE Editor Plugin</a> has been updated. Currently it uses your existing configuration. By editing the plugin, you can now assign and customise various layouts to specific user groups. <br />Warning: when editing the plugin, you will lose all your previous settings!

avatar infograf768 infograf768 - open - 31 Mar 2017
avatar infograf768 infograf768 - change - 31 Mar 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 31 Mar 2017
Category Administration Language & Strings
avatar brianteeman
brianteeman - comment - 31 Mar 2017

Isn't that warning something that is obvious and therefore not needed. I guess I am missing the need for this extra text. Less is always more

avatar infograf768
infograf768 - comment - 31 Mar 2017

I have many returns that this is not as obvious as it is for some aware of the changes, thus this PR.

avatar AlexRed AlexRed - test_item - 31 Mar 2017 - Tested successfully
avatar AlexRed
AlexRed - comment - 31 Mar 2017

I have tested this item successfully on d1c259c

Patch ok for me. Thanks


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15024.

avatar Fedik
Fedik - comment - 31 Mar 2017

Warning: when editing the plugin, you will lose all your previous settings!

not all, but half 😉
example the "image upload folder", "language" and other stuff in the form, will work as before

just the note, nothing against the changes 😉

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 31 Mar 2017 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 31 Mar 2017

I have tested this item successfully on d1c259c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15024.

avatar franz-wohlkoenig franz-wohlkoenig - change - 31 Mar 2017
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 31 Mar 2017

RTC after two successful testes.

avatar brianteeman
brianteeman - comment - 31 Mar 2017

Please consider removing the RTC on this. As @Fedik says it is not correct/accurate

avatar franz-wohlkoenig franz-wohlkoenig - change - 31 Mar 2017
Status Ready to Commit Pending
avatar infograf768
infograf768 - comment - 31 Mar 2017

@Fedik what do you suggest?
'lose part of your previous settings!'
?

avatar AlexRed
AlexRed - comment - 31 Mar 2017

Functionality (preset) is lose

avatar Fedik
Fedik - comment - 31 Mar 2017

hm, no idea

maybe like: "Be aware. Existing toolbar/TinyMCE settings cannot be fully migrated, they will be adopted partially."

or something similar

avatar AlexRed
AlexRed - comment - 31 Mar 2017

"Be aware. Existing toolbar/TinyMCE settings cannot be fully migrated, they will be adopted partially."
ok for me

avatar infograf768
infograf768 - comment - 31 Mar 2017

@brianteeman is that proposal good english enough ?

avatar franz-wohlkoenig franz-wohlkoenig - change - 1 Apr 2017
Priority Medium Low
avatar infograf768
infograf768 - comment - 2 Apr 2017

@brianteeman
Waiting for your feedback concerning a better English for Fedik proposal as It does not sound good to me (adopted for example).

avatar brianteeman
brianteeman - comment - 2 Apr 2017

"Be aware. Existing toolbar/TinyMCE settings cannot be fully migrated, they may only be partially adopted."

??

avatar infograf768
infograf768 - comment - 3 Apr 2017

Dies that mean it is OK for you (the English phrasing I mean) ?

avatar franz-wohlkoenig franz-wohlkoenig - change - 3 Apr 2017
Easy No Yes
avatar franz-wohlkoenig franz-wohlkoenig - change - 6 Apr 2017
Priority Low Medium
Status Pending Needs Review
avatar AlexRed
AlexRed - comment - 7 Apr 2017

RC1 is released and that also means language freeze is in effect now. I think this issues is now for Joomla 3.7.1 :(

avatar infograf768
infograf768 - comment - 7 Apr 2017

Yeah, I was waiting for a reply from Brian. Did not get any.

avatar infograf768
infograf768 - comment - 7 Apr 2017

It is still possible though to let TTs know after merging a corrected value for that string.

avatar stellainformatica stellainformatica - test_item - 7 Apr 2017 - Tested successfully
avatar stellainformatica
stellainformatica - comment - 7 Apr 2017

I have tested this item successfully on d1c259c

The patch is ok for me


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15024.

avatar franz-wohlkoenig franz-wohlkoenig - change - 7 Apr 2017
Status Needs Review Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 7 Apr 2017

RTC after 3 successful testes.

avatar rdeutz rdeutz - change - 22 May 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-05-22 18:57:10
Closed_By rdeutz
Labels Added: Language Change RTC
avatar rdeutz rdeutz - close - 22 May 2017
avatar rdeutz rdeutz - merge - 22 May 2017

Add a Comment

Login with GitHub to post a comment