[#15013] - [com_fields] Moving dd tag from field JLayout to fields JLayout
- Fixed in Code Base
- 18 Apr 2017
- Medium
- Build: staging
- # 15013
- Diff
- Bakual:FixFieldsLayout
User tests: Successful: Unsuccessful:
Pull Request for Issue #14753 .
Summary of Changes
Moving the <dd> tag from the "field" Jlayout to the "fields" Jlayout where also the <dl> tag is defined
Testing Instructions
- Create a field and assign a value to it
- Set the tag to automatic display plus insert it into the article using the field button.
- Check article in frontend, the automatic display should have the
<dl>and<dd>tags around the field, but the one in the article should not have any of them.
Expected result
See testing instructions.
Actual result
<dd> tag appears also in article, creating invalid HTML.
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_fields |
I would rather use a second layout, instead of using a one for all solution. Like that it is much easier for the admin to handle the layouts. Just my 2 cents here.
Actually, the <dd> tag should be in the layout specifying the <dl> tag anyway. There is no reason to have that one in the field layout. So this change is needed anyway, even if we want to do two different layouts (which I don't see any need for) later.
| Title |
|
||||||
| Labels |
Added:
?
|
||||||
As you cant have a dd without a dl it makes sense to me that they are in the same layout. And if they dont want to have a definition list then they are only overriding/customising one file
As you can't have a dd without a dl
That's an argument.
franz-wohlkoenig
- | Status | Pending | ⇒ | Discussion |
nibra
- | Title |
|
||||||
Don't forget the override in com_contact.
Don't forget the override in com_contact.
I had a look at that one when I wrote the PR. I think we can leave that one as it is.
We can't move the dt and dd into the parent layout there, or we would have to render the label (wrapped into the dt) in the parent one. Which I think is a bit pointless as well.
| Title |
|
||||||
| Title |
|
||||||
| Title |
|
||||||
rdeutz
- | Status | Discussion | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-04-18 06:38:20 |
| Closed_By | ⇒ | rdeutz |
I have tested this item✅ successfully on fc933d5
Patch ok for me
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15013.