[#15002] - Allow menu item separators to have labels in admin menu
- Fixed in Code Base
- 2 Apr 2017
- Medium
- Build: staging
- # 15002
- Diff
- izharaazmi:am-group-separator
User tests: Successful: Unsuccessful:
Summary of Changes
-
Added an optional title parameter to
addSeparator()method in backend menu class. Hence there are now two separator types:- Normal Separator (horizontal bar)
- Labelled Separator
-
In the preset menu, converted the separators between menus to labelled separators. This helps identify which menu are site menus and which are administrator menus.
-
This labelled separators can also be used in the new custom backend menu by simply providing a label to the separator type menu item.
Testing Instructions
- Install current staging and navigate to backend and see the drop down menu.which should look like
- Add a custom administrator menu and set it as active backend menu.
- Add some items, separators with title and separators without title in custom backend menu
- Match your findings with expected results below.
- If there is no admin menu,the separator should also be hidden automatically.
- Test this on RTL layout also.
Expected result
- The separators with title should appear as labelled separators whereas the separator without title should be displayed as normal separator.
- The separators should not be clickable
Documentation Changes Required
Backend menu manager documentation should be updated.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Modules Administration Templates (admin) |
Sorry, I've no idea how to do that. Please advise.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15002.
The LESS files are in the template directory. To compile, you're going to need to open up your terminal, cd to the Joomla root, and run php build/generatecss.php.
Thanks. I was trying to use PHPStorm LESS Watcher for no avail. It
displayed so many errors. Didn't know there was a script for that. Doing it
now.
| Labels |
Added:
?
|
||
| Category | Modules Administration Templates (admin) | ⇒ | Modules Administration Templates (admin) Front End Templates (site) |
Appended from System Links: Menu Heading and Text Separator to Costum Menu, none of them is showen.
again, could you please remove the asterisk from your CSS.
*width: 100%;
^
*margin: -5px 0 5px;
^
@franz-wohlkoenig Separators at beginning or end or immediately after another separator - are never shown.
@C-Lodder Those are already there in the divider less definition, I thing for IE only rule. See administrator/templates/isis/less/bootstrap/mixins.less:502
I recommend we have a test on IE too.
@izharaazmi - we don't support IE7
@izharaazmi please have a look:
I have tested this item System Links > Text Separator with Text or - in Title-Field works.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15002.
Changed from Separator using - in Title to Name in Title no Name is shown. Looks like Cache but had cleared Browser-Cache:
@franz-wohlkoenig You need to use separator type instead of heading.
I tested changing title from - to text and also the other way around. All looks fine here.
@brianteeman can you please retest?
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15002.
| Status | Pending | ⇒ | Ready to Commit |
RTC after two successful testes.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15002.
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-04-02 19:16:42 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
|
||
After updating to 3.7 I desperately tried to create unnamed separators in a custom backend menu. Only here on Github I found I could achieve this by naming it with a single hyphen (-). In my opinion, this is not at all intuitive. How are users supposed to know that?
What's more when named with a single hyphen, the menu item is quite hard to click in the menu item list. Of course I can select the item and use the "edit" button, but who the heck actually does it this way?
I think it would be far more elegant to have a "Use title as separator label" property. And this should be switched off by default, which would be more the default behaviour of a "separator" imho.
I will, thanks.
Can you please make styling changes in the correct LESS file and compile it