? Pending

User tests: Successful: Unsuccessful:

avatar laoneo
laoneo
30 Mar 2017

Move CMS tables to namespace.

avatar laoneo laoneo - open - 30 Mar 2017
avatar laoneo laoneo - change - 30 Mar 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 30 Mar 2017
Category Libraries
avatar brianteeman
brianteeman - comment - 30 Mar 2017

if the class name changes then shouldnt the @since version change as well. #askingforafriend

avatar laoneo
laoneo - comment - 30 Mar 2017

I don't think so as the class stays the same and does the same, just the name changed.

avatar mbabker
mbabker - comment - 30 Mar 2017

Personally I wouldn't change them either. If anything a @note As of x.y this class was renamed from <old_class> annotation would be as far as I'd go.

avatar brianteeman
brianteeman - comment - 30 Mar 2017

Thanks - was just asking

avatar photodude
photodude - comment - 30 Mar 2017

strange that this is failing with

Fatal error: Class 'Joomla\Cms\Component\JFactory' not found in libraries\src\Joomla\Cms\Component\ComponentHelper.php on line 91
avatar laoneo
laoneo - comment - 30 Mar 2017

You need to have this one installed first #14996, it fixes some merge invalidity.

avatar laoneo laoneo - change - 3 Apr 2017
Labels Added: ?
8e310cf 4 Apr 2017 avatar wilsonge Fix
avatar mbabker
mbabker - comment - 8 Apr 2017

This needs syncing again please.

avatar laoneo
laoneo - comment - 10 Apr 2017

Thanks @wilsonge. When one namespacing pr got merged, then there will be always a conflict in the classmap file in the other open ones.

508e0c0 10 Apr 2017 avatar laoneo doc
c4c869f 10 Apr 2017 avatar laoneo fix
avatar laoneo
laoneo - comment - 10 Apr 2017

So, fixed some minor things and changed to getInstance

avatar mbabker mbabker - change - 10 Apr 2017
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-04-10 16:05:06
Closed_By mbabker
avatar mbabker mbabker - close - 10 Apr 2017
avatar mbabker mbabker - merge - 10 Apr 2017

Add a Comment

Login with GitHub to post a comment