[#14986] - [a11y] ordering icons
- Fixed in Code Base
- 30 Mar 2017
- Medium
- Build: staging
- # 14986
- Diff
- brianteeman:a11y-drag
- Pending continuous-integration/drone/pr this build is pending Details
User tests: Successful: Unsuccessful:
When reading our default markup for rendering icons, assisistive technology may have the following problems.
The assistive technology will not find any content to read out to a user
The assistive technology will read the unicode equivalent, which does not match up to what the icon means in context, or worse is just plain confusing. In our use case it is always plain wrong. For example the unicode character used to display the trashed icon is \4c which is equal to L
When an icon is not an interactive element the simplest way to provide a text alternative is to use the aria-hidden="true" attribute on the icon and to include the text with an additional element, such as a < span>, with appropriate CSS to visually hide the element while keeping it accessible to assistive technologies.
In this case as the drag icon is completely inaccessible for non-sighted users (out of scope to resolve for this PR) we just need to add the aria-hidden to prevent the icon being "read aloud"
This PR addresses the use case for the drag icons shown in the image below
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_banners com_contact com_content com_fields com_languages com_menus com_newsfeeds com_plugins com_users |
| Labels |
Added:
?
|
||
I have tested this item
code review
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14986.
In these files too:
\administrator\components\com_categories\views\categories\tmpl\default.php
\administrator\components\com_modules\views\modules\tmpl\default.php
\administrator\components\com_tags\views\tags\tmpl\default.php
| Category | Administration com_banners com_contact com_content com_fields com_languages com_menus com_newsfeeds com_plugins com_users | ⇒ | Administration com_banners com_categories com_contact com_content com_fields com_languages com_menus com_modules com_newsfeeds com_plugins com_tags com_users |
| Category | Administration com_banners com_contact com_content com_fields com_languages com_menus com_newsfeeds com_plugins com_users com_categories com_modules com_tags | ⇒ | Administration com_banners com_contact com_content com_fields com_languages com_menus com_newsfeeds com_plugins com_users |
@quy thats because they were changed in a different PR. Downside of making so many changes is that you have to break it up into smaller ones to prevent conflicts and make it easier to renew. Sometimes that will mean there will be some extra changes made after all the current PR have been merged. Once they are all merged i will do another pass through to catch any that might have been missed
I have tested this item
Code review.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14986.
@franz-wohlkoenig there is no need for a retest. The test count was reset because I made a change to the PR but then I reverted that change so @C-Lodder test is still good
| Status | Pending | ⇒ | Ready to Commit |
RTC after two successful testes.
wilsonge
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-03-30 11:48:18 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
Don't remove closing span tags. That's invalid HTML.