[#14974] - [a11y] Span not i and icons
- Fixed in Code Base
- 29 Mar 2017
- Medium
- Build: staging
- # 14974
- Diff
- brianteeman:a11y-i-span
User tests: Successful: Unsuccessful:
Convert the last batch of icons that had an i tag instead of a span and continue the work to make sure they have aria-hidden=true so that a screenreader wont try to read the font character
Please note that after applying this PR there may still be instances of an i tag - that is because there are other similar PRs awaiting testing/merge
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_finder com_modules com_users Templates (admin) Layout Libraries Front End Templates (site) |
To start with make sure that the icons are still displayed.
@brianteeman Icons at View "Articles" (New, Edit, ...; in Column "Status") are shown – you mean this Icons?
@franz-wohlkoenig - sorry, should have stated, this was a code review test.
I have tested this item
Code review.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14974.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-03-29 19:29:54 |
| Closed_By | ⇒ | zero-24 | |
| Labels |
Added:
?
|
||
Thanks merged!
Thanks
I have tested this item✅ successfully on daf6a09
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14974.