[#14970] - [com_fields] Use the color rule for the color field
- Fixed in Code Base
- 4 Apr 2017
- Medium
- Build: staging
- # 14970
- Diff
- Digital-Peak:cf/color-rule
User tests: Successful: Unsuccessful:
Summary of Changes
To validate the color value in the color field, the color rule should be used. The doc blocks got updated of the onCustomFieldsPrepareDom function is they have been outdated.
Potential BC break
Additionally the color rule was changed to have the same behavior as the other rules when an empty value is passed and the field is not required. IMO this is not a BC break but a bug fixed, @Bakual, @mbabker and @wilsonge what you guys think?
Testing Instructions
- Create a color field
- Set a wrong default value like 'nocolor'
Expected result
An error should be shown that the field could not be saved.
Actual result
An error should be shown that the field could not be saved.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries Front End Plugins |
| Title |
|
||||||
| Labels |
Added:
?
|
||
| Category | Libraries Front End Plugins | ⇒ | Administration com_fields Libraries Front End Plugins |
| Category | Libraries Front End Plugins Administration com_fields | ⇒ | Administration com_fields Libraries Front End Plugins Unit Tests |
| Labels |
Added:
?
|
||
| Category | Libraries Front End Plugins Administration com_fields Unit Tests | ⇒ | Administration com_fields Front End Plugins |
| Labels |
Removed:
?
|
||
| Category | Front End Plugins Administration com_fields | ⇒ | Administration com_fields Libraries Front End Plugins Unit Tests |
Additionally the color rule was changed to have the same behavior as the other rules when an empty value is passed and the field is not required. IMO this is not a BC break but a bug fixed, @Bakual, @mbabker and @wilsonge what you guys think?
Should be fine imho. Nothing could break anyway, it just allows an empty value now if the field is not required, which makes sense for a not-required field.
If that one got merged, then I will prepare another pr which unify the required check as it is redundant code across all rules. But first let's get that one in first
@franz-wohlkoenig thats black
oh ok, thats not what you said
so i expect that #000000 got something like #123456
Why should it be transformed that way? It should keep the value.
No it doesn't but it will not be possible to save it with invalid colors.
You can use any string as invalid hex code which doesn't represent a hex color. I'm not even sure if this can be reproduced with modifying the request as the javascript code is always reverting to a color hex code or is clearing the field when editing the article. I guess at the end of the day it has to be merged by review as the unit tests do all pass.
so its better for Tester to adapt Test instructions to "code review"?
Ok, updated the test instructions.
| Labels |
Added:
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14970.
I have tested this item
An error is shown that the field could not be saved.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14970.
| Status | Pending | ⇒ | Ready to Commit |
RTC after two successful testes.
Thanks, guys!
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-04-04 19:06:24 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
|
||
Thanks @brianteeman. I had to change the whole doc block as it was very outdated and did contain invalid information.