[#14894] - Update default.php to fix missing space between img attributes
- Fixed in Code Base
- 31 Mar 2017
- Medium
- Build: staging
- # 14894
- Diff
- BastianWie:master
User tests: Successful: Unsuccessful:
Pull Request for Issue #14893 .
Summary of Changes
Added the correct space between the attributes inside the banner elements
Testing Instructions
Overwrite the default.php in a joomla 3.6.5 with the fixed one. Try the steps from issue #14893 and check the HTML source. The spaces should be now correct. As an additional test you can run an HTML syntax check against the section and it now validated correctly.
Expected result
img src="banners/banner_example_468x60.gif" alt="486x60" width="486" height="60"/
Actual result
img src="banners/banner_example_468x60.gif" alt="486x60"width ="486"height ="60"/
Documentation Changes Required
See source code
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Modules Front End |
| Labels |
Added:
?
|
||
| Title |
|
||||||
Are you getting your error on a completely clean install of joomla without any extensions
I don't know if it's really a markup error but would also prefer to remove these spaces (what the PR does):
More consistent and some common regular expressions in 3rd extensions could fail
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14894.
The screenshot from bertmert shows the issue and the space between the width and height elements
Indeed, when looking at source, we have extra spaces
<div class="banneritem">
<img
src="http://localhost:8888/trunkgitnew/images/banners/white.png"
alt="my alt text"
width ="300" height ="150" />
The xtra spaces don't show when using Firebug.
After patch we do get the correct
<div class="banneritem">
<img
src="http://localhost:8888/trunkgitnew/images/banners/white.png"
alt="my alt text"
width="300" height="150" />
Not a big deal. But the PR incorrectly (code style) takes off the space before the ?>
for all instances of
- src="<?php echo $baseurl . $imageurl; ?>"
- alt="<?php echo $alt; ?>"
TO
+ src="<?php echo $baseurl . $imageurl;?>"
+ alt="<?php echo $alt;?>"
As these are variables the space does not have to be taken off.
yes its not a security issue or caused any known "issues". Its only to follow standards and get a cleaner code basis.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14894.
@infograf768 There is no change done for the src & alt section by me in my PR. You can check the change history. I fixed only the issue reported here with weigh and height.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14894.
There is a change: I posted it above. You took off some spaces. It is only a code style issue but it is real.
Just copy https://github.com/joomla/joomla-cms/pull/14894.diff in a text editor and you will see.
| Status | Pending | ⇒ | Ready to Commit |
RTC after two successful testes.
@infograf768 anything what needs fixing before merge?
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-03-31 12:57:59 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
|
||
I ran an html checker BEFORE the pr and didnt reveal any errors