? Pending

User tests: Successful: Unsuccessful:

avatar Spudley
Spudley
24 Mar 2017

Pull Request for Issue #14420.

Summary of Changes

In the user profile plugin, if there are no user profile fields to display, then do not show the user profile tab.

Testing Instructions

  • Start with a standard Joomla installation.
  • Activate the User Profile plugin, and set all fields to disabled except for the Terms Of Service field.
  • Create a new user via normal front-end registration form. ToS field should appear on the registration form, but no other profile fields.
  • Now switch to the admin panel, and bring up the new user's details in the user management.
  • Note that the user profile tab should not appear.

Expected result

  • After this change, the profile tab should not be shown in this case, as there would be no fields on it to display.

Actual result

  • In current Joomla (3.6.5) and earlier, given the above scenario, the profile tab would appear in the management tab, but clicking on the tab would just give you a blank form.

Documentation Changes Required

None.

avatar Spudley Spudley - open - 24 Mar 2017
avatar Spudley Spudley - change - 24 Mar 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 24 Mar 2017
Category Front End Plugins
avatar Spudley Spudley - change - 24 Mar 2017
Labels Added: ?
avatar zero-24
zero-24 - comment - 24 Mar 2017

Can you please target the PR against staging? And add a clean line before the if statment?

avatar Spudley
Spudley - comment - 24 Mar 2017

@zero-24: Yes, I can do. I avoided staging as I thought that's for 3.7 and given 3.7 is in beta, you wouldn't want anything other than bug fixes for it now.

Hmmm... okay, that's not working the way I want it to! Let me re-submit a fresh PR.

avatar Spudley Spudley - change - 24 Mar 2017
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2017-03-24 17:24:48
Closed_By Spudley
avatar Spudley Spudley - close - 24 Mar 2017

Add a Comment

Login with GitHub to post a comment