Feeling Lucky
?
[#14883] - JCategories: Setting at least the current category as part of the path
- Closed
- 30 Dec 2018
- Medium
- Build: staging
- # 14883
- Diff
- Hackwar:patch-18
User tests: Successful: Unsuccessful:
Our category system is slightly inconsistent and fails in one area. In JCategories/JCategoryNode, when the parent category is the root category, setParent() seems not to be called on JCategoryNode. This results in the the _path attribute being empty, although it should at least contain its own category. This is fixed with this one-liner.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Labels |
Added:
?
|
||
roland-d
- comment
- 22 Jul 2018
@Hackwar Can you fix this PR please?
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14883.
infograf768
- comment
- 23 Jul 2018
AND reply to the comment #14883 (comment)
Hackwar
- comment
- 30 Dec 2018
So I went through this code several times and while I'm pretty sure that I had a really, really good reason for this PR, I have no idea how to replicate this and see no issue anymore. So I'm closing this one.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-12-30 19:52:29 |
| Closed_By | ⇒ | Hackwar |
Travis and Test fail.
Could you please give test instructions and compare a present url with the one we should get after patch?