User tests: Successful: Unsuccessful:
Pull Request for Issue #14825 .
@stellainformatica does this resolve the issue?
Status | New | ⇒ | Pending |
Category | ⇒ | Front End com_contact |
yeah i spotted that too - dont know where its coming from :(
I have tested this item
Cause this Solution is better than before.
Won't resolve the extra space before the , :( but will fix anyway
Re-Applied PR with same Result
Labels |
Added:
?
|
@brianteeman you can do it this way instead:
<?php $location = array(); ?>
<?php if ($this->params->get('show_suburb_headings') && !empty($item->suburb)) : ?>
<?php $location[] = $item->suburb; ?>
<?php endif; ?>
<?php if ($this->params->get('show_state_headings') && !empty($item->state)) : ?>
<?php $location[] = $item->state; ?>
<?php endif; ?>
<?php if ($this->params->get('show_country_headings') && !empty($item->country)) : ?>
<?php $location[] = $item->country; ?><br />
<?php endif; ?>
<?php echo implode($location, ', '); ?>
I have tested this item
I have tested this item
I have tested this item
I have tested this item
I have tested this item
The patch works fine, thanks
RTC as there are 2 successfully Tests?
Status | Pending | ⇒ | Ready to Commit |
RTC
Maybe this hasn't a viewable effect but you removed a
at the end, was this intended?
Yes removing the br was intentional
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-03-23 21:04:35 |
Closed_By | ⇒ | rdeutz | |
Labels |
Added:
?
|
Using " City or Suburb " works, using " City or Suburb " too, is a Space before Comma to much: