? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
21 Mar 2017

Pull Request for Issue #14825 .

@stellainformatica does this resolve the issue?

avatar brianteeman brianteeman - open - 21 Mar 2017
avatar brianteeman brianteeman - change - 21 Mar 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 21 Mar 2017
Category Front End com_contact
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 21 Mar 2017

Using " City or Suburb " works, using " City or Suburb " too, is a Space before Comma to much:
1

avatar brianteeman
brianteeman - comment - 21 Mar 2017

yeah i spotted that too - dont know where its coming from :(

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 21 Mar 2017 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 21 Mar 2017

I have tested this item successfully on 41b7fc6

Cause this Solution is better than before.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14827.

avatar brianteeman
brianteeman - comment - 21 Mar 2017

Won't resolve the extra space before the , :( but will fix anyway

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 21 Mar 2017

Re-Applied PR with same Result

avatar brianteeman brianteeman - change - 21 Mar 2017
Labels Added: ?
avatar C-Lodder
C-Lodder - comment - 21 Mar 2017

@brianteeman you can do it this way instead:

<?php $location = array(); ?>

<?php if ($this->params->get('show_suburb_headings') && !empty($item->suburb)) : ?>
	<?php $location[] = $item->suburb; ?>
<?php endif; ?>

<?php if ($this->params->get('show_state_headings') && !empty($item->state)) : ?>
	<?php $location[] = $item->state; ?>
<?php endif; ?>

<?php if ($this->params->get('show_country_headings') && !empty($item->country)) : ?>
	<?php $location[] = $item->country; ?><br />
<?php endif; ?>

<?php echo implode($location, ', '); ?>
avatar dgt41
dgt41 - comment - 21 Mar 2017

@C-Lodder was faster :)

avatar brianteeman
brianteeman - comment - 21 Mar 2017

Thanks @C-Lodder looks ok now and ready for retesting

before with the extra ,

screenshotr17-23-34

after without the extra , or the extra spaces

screenshotr17-24-04

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 21 Mar 2017 - Tested successfully
avatar C-Lodder C-Lodder - test_item - 21 Mar 2017 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 21 Mar 2017

I have tested this item successfully on d769008


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14827.

avatar C-Lodder
C-Lodder - comment - 21 Mar 2017

I have tested this item successfully on d769008


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14827.

avatar brianteeman
brianteeman - comment - 21 Mar 2017

I removed the br as suggested but it didnt seem to need placing elsewhere
screenshotr18-30-03

avatar C-Lodder C-Lodder - test_item - 21 Mar 2017 - Tested successfully
avatar C-Lodder
C-Lodder - comment - 21 Mar 2017

I have tested this item successfully on 6be694c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14827.

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 21 Mar 2017 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 21 Mar 2017

I have tested this item successfully on 6be694c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14827.

avatar stellainformatica stellainformatica - test_item - 22 Mar 2017 - Tested successfully
avatar stellainformatica
stellainformatica - comment - 22 Mar 2017

I have tested this item successfully on 6be694c

The patch works fine, thanks


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14827.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 22 Mar 2017

RTC as there are 2 successfully Tests?

avatar jeckodevelopment jeckodevelopment - change - 22 Mar 2017
Status Pending Ready to Commit
avatar jeckodevelopment
jeckodevelopment - comment - 22 Mar 2017

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14827.

avatar rdeutz
rdeutz - comment - 23 Mar 2017

Maybe this hasn't a viewable effect but you removed a
at the end, was this intended?

avatar brianteeman
brianteeman - comment - 23 Mar 2017

Yes removing the br was intentional

avatar rdeutz rdeutz - close - 23 Mar 2017
avatar rdeutz rdeutz - merge - 23 Mar 2017
avatar rdeutz rdeutz - change - 23 Mar 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-03-23 21:04:35
Closed_By rdeutz
Labels Added: ?

Add a Comment

Login with GitHub to post a comment