[#14821] - Remove unused php version check
- Fixed in Code Base
- 22 May 2017
- Medium
- Build: staging
- # 14821
- Diff
- brianteeman:COM_CPANEL_MSG_PHPVERSION_TITLE
User tests: Successful: Unsuccessful:
Pull Request for Issue #14820 .
Summary of Changes
We have code in 3.7 still that runs postinstall and checks that you are on a version of php > 5.3.10 and if not gives the following message
Your PHP Version Will Be Unsupported in Joomla! 3.3
Beginning with Joomla! 3.3, the version of PHP this site is using will no longer be supported. Joomla! 3.3 will require at least <a href="QQ"https://community.joomla.org/blogs/leadership/1798-raising-the-bar-on-security.html"_QQ_">PHP version 5.3.10 in order to provide enhanced security features to its users."
This is now redundant and both the strings and the code \administrator\components\com_admin\postinstall\phpversion.php can be removed now as it is no longer possible to ever get that scenario
This PR removes the unused check and deprecates the language strings (in accordance with current language string policy)
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_admin Language & Strings |
Approval doesn't mean testing. It's effectively code review which as you like to say is not the same thing as a test (and given half my contributions probably correctly - so no it still needs actual tests)
It will be very hard to do anything other than a code review as the code is never used
@wilsonge How to test this?
When I attempted to install Joomla 3.6.5 on PHP 5.3.3, I got this error message so installation halted:
Your host needs to use PHP 5.3.10 or higher to run this version of Joomla!
With the following code at the beginning in index.php, administrator\index.php, and installation\index.php. Joomla won't run and you won't see the postinstall message about Joomla! 3.3.
define('JOOMLA_MINIMUM_PHP', '5.3.10');
if (version_compare(PHP_VERSION, JOOMLA_MINIMUM_PHP, '<'))
{
die('Your host needs to use PHP ' . JOOMLA_MINIMUM_PHP . ' or higher to run this version of Joomla!');
}
| Labels |
Added:
?
?
|
||
| Milestone |
Added: |
||
| Status | Pending | ⇒ | Ready to Commit |
| Labels | |||
RTC for 3.7.1
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14821.
| Labels |
Added:
?
|
||
conflict resolved no need for new tests
@brianteeman i have just fixed the script.php files
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-05-22 18:55:42 |
| Closed_By | ⇒ | rdeutz |
Thanks
This PR has been approved by two people - should it not be RTC?