? ? Pending

User tests: Successful: Unsuccessful:

avatar ciar4n
ciar4n
20 Mar 2017

Pull Request for Issue # .

Summary of Changes

Some alerts fail WCAG AA. This style change allows them to pass.

Testing Instructions

Apply patch and navigate admin, checking alerts.

alert

Documentation Changes Required

avatar ciar4n ciar4n - open - 20 Mar 2017
avatar ciar4n ciar4n - change - 20 Mar 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 20 Mar 2017
Category Administration Templates (admin)
avatar ciar4n ciar4n - change - 20 Mar 2017
The description was changed
avatar ciar4n ciar4n - edited - 20 Mar 2017
avatar franz-wohlkoenig franz-wohlkoenig - test_item - 20 Mar 2017 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 20 Mar 2017

I have tested this item successfully on 6b718ba


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14813.

avatar ciar4n ciar4n - edited - 20 Mar 2017
avatar dgt41
dgt41 - comment - 20 Mar 2017

@ciar4n maybe a total override of the default bootstrap variables is easier
Also you committed you configuration here, you need to revert that :)

avatar ciar4n ciar4n - change - 20 Mar 2017
Title
[4.0] Alert color change to pass WCAG AA
[4.0] [a11y] Alert color change to pass WCAG AA
Labels Added: ?
avatar ciar4n
ciar4n - comment - 20 Mar 2017

@dgt41 Yep. In this PR I override the mixin which creates the alert. I agree if we continue making such changes a total override is the way to go. Currently everything added in ../administrator/templates/atum/scss/vendor/bootstrap/ is extra CSS to load.

avatar brianteeman brianteeman - test_item - 20 Mar 2017 - Tested successfully
avatar brianteeman
brianteeman - comment - 20 Mar 2017

I have tested this item successfully on 4669896

These colour combos pass the a11y standards - I will leave the comment of @dgt41 to others who understand the code aspect better ;)


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14813.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 21 Mar 2017

RTC as there are 2 successfully Tests?

avatar jeckodevelopment jeckodevelopment - change - 21 Mar 2017
Status Pending Ready to Commit
avatar jeckodevelopment
jeckodevelopment - comment - 21 Mar 2017

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14813.

avatar C-Lodder
C-Lodder - comment - 23 Mar 2017

@wilsonge - please merge

avatar wilsonge wilsonge - change - 23 Mar 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-03-23 21:10:00
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 23 Mar 2017
avatar wilsonge wilsonge - merge - 23 Mar 2017

Add a Comment

Login with GitHub to post a comment