? ? Pending

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
20 Mar 2017

Pull Request for Issue #14796

Summary of Changes

Prevent loading default language en-GB when debug language is ON

Testing Instructions

Install a site with 2 languages. Set the administrator language to else than en-GB.
Delete some ini files from the other language.
(In #14796 com_associations.ini did not exist for the 3.6.5 language packs.)

Set Debug Language ON in Global configuration.

Expected result

As the ini file is missing, constants should be displayed as ??CONSTANT??

Actual result

en-GB replaces the missing values because the language does not contain the ini file

screen shot 2017-03-20 at 11 34 54

PATCH and retest

You should now get this (example with com_associations. Admin lang is Italian in this case.

screen shot 2017-03-20 at 11 24 11

@Bakual @mbabker @zero-24

avatar infograf768 infograf768 - open - 20 Mar 2017
avatar infograf768 infograf768 - change - 20 Mar 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 20 Mar 2017
Category Libraries
avatar infograf768
infograf768 - comment - 20 Mar 2017

Forgot: also check when debug is OFF and when one string is missing in an ini file (OFF and ON)

avatar AlexRed AlexRed - test_item - 20 Mar 2017 - Tested successfully
avatar AlexRed
AlexRed - comment - 20 Mar 2017

I have tested this item successfully on 0434ce4

Patch ok for me


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14801.

avatar stellainformatica stellainformatica - test_item - 20 Mar 2017 - Tested successfully
avatar stellainformatica
stellainformatica - comment - 20 Mar 2017

I have tested this item successfully on 0434ce4


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14801.

avatar infograf768 infograf768 - change - 20 Mar 2017
Status Pending Ready to Commit
avatar infograf768
infograf768 - comment - 20 Mar 2017

RTC. To whoever merges, please check that it has no unwanted effect. (Did not see any).


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14801.

avatar rdeutz rdeutz - change - 21 Mar 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-03-21 18:39:05
Closed_By rdeutz
Labels Added: ? ?
avatar rdeutz rdeutz - close - 21 Mar 2017
avatar rdeutz rdeutz - merge - 21 Mar 2017

Add a Comment

Login with GitHub to post a comment