This is not correct. Yes the text will only be used for screen readers but you are not preventing the screenreader from reading out the unicode value of the fontawesome icon that is being used.

See http://fontawesome.io/accessibility/

I have tested this item ? unsuccessfully on 2358606

this is not correct see See http://fontawesome.io/accessibility/

Also there are several changes that are unrelated to com-messages that should not be here

You cannot just use an automated testing tool to test screenreader issues - especially when it relates to icons.

body p { margin-bottom: 0cm; margin-top: 0pt; } 


Fine - I will (re) implement it in this way :-)

On 20/03/17 13:05, Brian Teeman wrote:


  @brianteeman commented on this pull request.
  
  In administrator/templates/atum/html/modules.php:
  > @@ -67,7 +67,7 @@ function modChrome_well($module, &$params, &$attribs)
		if ($canEdit)
		{
			echo '<div class="btn-group module-dropdown">';

•   		echo '<a href="#" data-toggle="dropdown"><span class="fa fa-cog"></span></a>';
  

•   		echo '<a href="#" data-toggle="dropdown"><span class="fa fa-cog"><span class="sr-only">' . JText::_('JACTION_EDIT') . " " . $module->title . '</span></span></a>';
  
  Taken directly from the fontawesome.io accessibility guide
  For icons that are decorative
    <span class="fa fa-envelope"
      aria-hidden=”true”></span>
  For icons that have semantic or interactive meaning
    <span class="fa fa-arrow-right" title="Submit My Tax
      Return"></span>
  One of the problem with the way that you ave done this is that
    if there is no title or aria-hidden=true attribute is that the
    screenreader will read the unicode value of the icon
  So for the coge the unicode is \f013 ad the screenreader will
    read that aloud as an EGYPTIAN HIEROGLYPH
  —
    You are receiving this because you authored the thread.
    Reply to this email directly, view
      it on GitHub, or mute
      the thread.
  
    
      
      
    
    
  
  {"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/joomla/joomla-cms","title":"joomla/joomla-cms","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/joomla/joomla-cms"}},"updates":{"snippets":[{"icon":"PERSON","message":"@brianteeman commented on #14799"}],"action":{"name":"View Pull Request","url":"https://github.com/joomla/joomla-cms/pull/14799#discussion_r106875141"}}}
  

please reassign Milestone 4.0, thanks.

Closing as the promised correction was never made