[#14797] - [com_fields] Encode the list options
- Fixed in Code Base
- 21 Mar 2017
- Medium
- Build: staging
- # 14797
- Diff
- Digital-Peak:cf/list-options-encode
User tests: Successful: Unsuccessful:
Pull Request for Issue #14609.
Summary of Changes
Encodes the value for the list options.
Testing Instructions
- Create a list custom field.
- Add an option with the text Test and the value test&demo.
- Add an option with the text Test1 and the value test.
- Edit an article.
Expected result
No error message is shown.
Actual result
An error is shown:
Warning: DOMElement::__construct(): unterminated entity reference b in //joomla-cms/administrator/components/com_fields/libraries/fieldslistplugin.php on line 44
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_fields |
Fails with R&B for the Text and Value.
Warning: FieldsListPlugin::onCustomFieldsPrepareDom(): unterminated entity reference B in C:\xampp\htdocs\joomla-cms-staging\administrator\components\com_fields\libraries\fieldslistplugin.php on line 45
Using the latest staging version from today.
Yep same for me, not working.. @laoneo
( ! ) Warning: FieldsListPlugin::onCustomFieldsPrepareDom(): unterminated entity reference b in /administrator/components/com_fields/libraries/fieldslistplugin.php on line 45
@franz-wohlkoenig did you test the article edit after you set up the field?
I have tested this item
(forgot to set Error Reporting on Maximum):
Warning is shown with an & or not in Field.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14797.
| Labels |
Added:
?
|
||
True, nodeValue does also need to be encoded.
@Quy when you have tested it successfully, can you mark it here https://issues.joomla.org/tracker/joomla-cms/14797. Thanks.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14797.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14797.
RTC as there are 2 successfully Tests?
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14797.
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-03-21 18:35:38 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
|
||
I have tested this item✅ successfully on 9c7539d
works also without PR.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14797.