? Pending

User tests: Successful: Unsuccessful:

avatar laoneo
laoneo
20 Mar 2017

Pull Request for Issue #14357.

Summary of Changes

It is not possible to clear all values in a list. This pr fixes it.

Additionally it clears up the onContentAfterSave function.

Testing Instructions

  • Create a list custom field with multiple options and set multiple to true.
  • Adit an article.
  • Select some options in the list field.
  • Save the article.
  • Edit the article.
  • Deselect all options in the list field.
  • Save the article.

Expected result

The list field is empty.

Actual result

The list field contains the values from the last save and is not empty.

Documentation Changes Required

avatar laoneo laoneo - open - 20 Mar 2017
avatar laoneo laoneo - change - 20 Mar 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 20 Mar 2017
Category Front End Plugins
avatar laoneo laoneo - change - 20 Mar 2017
The description was changed
avatar laoneo laoneo - edited - 20 Mar 2017
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 20 Mar 2017

Lang.Strin missed:
bildschirmfoto 2017-03-20 um 09 41 46

avatar laoneo
laoneo - comment - 20 Mar 2017

Guess you need to update your branch to the latest staging.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 20 Mar 2017

same on latest staging.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 20 Mar 2017

Select some options in the list field.

only one Option can be selected

Deselect all options in the list field.

one Option is alway selected.

avatar laoneo
laoneo - comment - 20 Mar 2017

Did you set multiple to true?

avatar laoneo
laoneo - comment - 20 Mar 2017

The label issue should be fixed with pr #14798.

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 20 Mar 2017 - Tested unsuccessfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 20 Mar 2017

I have tested this item ? unsuccessfully on 86d58bc

The list field contains the values from the last save and is not empty.

Thanks for fixing Lang.String, multiple was not set on Yes?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14795.
avatar laoneo
laoneo - comment - 20 Mar 2017

There was a problem when there is only one field and it doesn't contain a value, then no data at all do arrive at the plugin. The last commit is handling that. Can you please test again.

@Bakual can you have a look also on the changes, just that I din't miss something.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 20 Mar 2017

@laoneo only 1 List-Field with 1 Fieldpair in 1 Fieldgroup?

avatar laoneo
laoneo - comment - 20 Mar 2017

With the latest commit all should work, so test whatever combination you want.

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 20 Mar 2017 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 20 Mar 2017

I have tested this item successfully on 86d58bc


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14795.

avatar brianteeman brianteeman - test_item - 20 Mar 2017 - Tested successfully
avatar brianteeman
brianteeman - comment - 20 Mar 2017

I have tested this item successfully on 86d58bc


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14795.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 21 Mar 2017

RTC as there are 2 successfully Tests?

avatar jeckodevelopment jeckodevelopment - change - 21 Mar 2017
Status Pending Ready to Commit
avatar jeckodevelopment
jeckodevelopment - comment - 21 Mar 2017

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14795.

avatar rdeutz rdeutz - close - 21 Mar 2017
avatar rdeutz rdeutz - merge - 21 Mar 2017
avatar rdeutz rdeutz - change - 21 Mar 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-03-21 18:33:47
Closed_By rdeutz
Labels Added: ?

Add a Comment

Login with GitHub to post a comment