? Pending

User tests: Successful: Unsuccessful:

avatar csthomas
csthomas
19 Mar 2017

Summary of Changes

  • Fix smart search indexer for mysql, related to #14811 for J3
  • Fix a few lines in front end template for smart search, take a look at code.

Testing Instructions

Go to backend - Smart Search extension.
Click on button "Index"
Test front end search form at index.php?option=com_finder&view=search
(type 'red' or 'green') - before patch there is error page, after patch joomla finds an item.

Expected result

All works, front end search form too.

Actual result

Expression #3 of SELECT list is not in GROUP BY clause and contains nonaggregated column 't1.stem' which is not functionally dependent on columns in GROUP BY clause; this is incompatible with sql_mode=only_full_group_by

Documentation Changes Required

No

avatar csthomas csthomas - open - 19 Mar 2017
avatar csthomas csthomas - change - 19 Mar 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 19 Mar 2017
Category Administration com_finder
avatar marcodings marcodings - test_item - 20 Mar 2017 - Tested successfully
avatar marcodings
marcodings - comment - 20 Mar 2017

I have tested this item successfully on d807fdb

Tested successfully aga8nst J37b3


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14783.

avatar wilsonge
wilsonge - comment - 20 Mar 2017

@csthomas can you rebase here please?

avatar csthomas csthomas - change - 20 Mar 2017
Labels Added: ?
avatar brianteeman
brianteeman - comment - 20 Mar 2017

@wilsonge why does it need rebasing this is for J4 and github reports no conflicts ?
@marcodings this is for J4 but you have tested on J3?

avatar wilsonge
wilsonge - comment - 20 Mar 2017

There were conflicts after #14782. It already got rebased since I asked which is why github doesn't show any conflicts now

avatar wilsonge wilsonge - test_item - 20 Mar 2017 - Tested unsuccessfully
avatar wilsonge
wilsonge - comment - 20 Mar 2017

I have tested this item ? unsuccessfully on a397af6

This fixes the term_id issue but I cannot index fully still. On running index with sample data I now get the error:

Field 'map_suffix' doesn't have a default value


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14783.

avatar joomla-cms-bot joomla-cms-bot - change - 20 Mar 2017
Category Administration com_finder Administration com_finder Front End
avatar csthomas
csthomas - comment - 20 Mar 2017

Please do not merge it for now. I'm working on version for J3

avatar csthomas csthomas - change - 20 Mar 2017
The description was changed
avatar csthomas csthomas - edited - 20 Mar 2017
avatar csthomas csthomas - change - 20 Mar 2017
The description was changed
avatar csthomas csthomas - edited - 20 Mar 2017
avatar csthomas csthomas - change - 20 Mar 2017
The description was changed
avatar csthomas csthomas - edited - 20 Mar 2017
avatar waader waader - test_item - 27 Mar 2017 - Tested successfully
avatar waader
waader - comment - 27 Mar 2017

I have tested this item successfully on 10848bd


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14783.

avatar wilsonge wilsonge - change - 11 Apr 2017
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-04-11 19:05:52
Closed_By wilsonge
avatar wilsonge wilsonge - close - 11 Apr 2017
avatar wilsonge wilsonge - merge - 11 Apr 2017

Add a Comment

Login with GitHub to post a comment