Failure

User tests: Successful: Unsuccessful:

avatar gunjanpatel
gunjanpatel
12 Jul 2013
  • This pull will fix the language string issue found during testing pull #705
    6859220_171792534_10883067
avatar gunjanpatel gunjanpatel - open - 12 Jul 2013
avatar gunjanpatel
gunjanpatel - comment - 13 Aug 2013
avatar Hackwar
Hackwar - comment - 7 Feb 2014

works like expected

avatar brianteeman
brianteeman - comment - 7 Feb 2014

backend please. we have 60+instances of backend and only 3 of back-end.

avatar gunjanpatel
gunjanpatel - comment - 10 Feb 2014

Thank you @brianteeman for review. I will change it to 'backend'.

avatar gunjanpatel
gunjanpatel - comment - 10 Feb 2014

Thanks you @Hackwar for test. :+1:

avatar Bakual
Bakual - comment - 10 Feb 2014

I'm not sure what the intend of this PR is. It seems to be related to another PR which isn't merged yet (and maybe never will).
If I understand this right, this doesn't fix a current issue with our core. If that's true, then this one can be closed.
If there is a bug in the other PR, please comment there and get it fixed before it gets merged.

If I'm wrong, please correct me :smile:

avatar Hackwar
Hackwar - comment - 10 Feb 2014

This is not aimed at another PR, but a codestyle fix for the current codebase. The name of the branch might be misleading. The "big" change is setting the autoloadlanguage flag, which results in the right message being displayed.

avatar Bakual
Bakual - comment - 10 Feb 2014

@Hackwar The "big" change is setting the autoloadlanguage flag, which results in the right message being displayed.

Yep, but that $autoloadLanguage = true is currently not needed since we don't use a language string from the plugin. It would load the language file for nothing. It would be needed if we merge the other PR, and thus should be done there.

avatar Hackwar
Hackwar - comment - 14 Jul 2014

@gunjanpatel could you update this PR?

avatar gunjanpatel
gunjanpatel - comment - 15 Jul 2014

Thanks @Hackwar and @Bakual for review. Should I send this PR against staging instead of master branch. and I will remove $autoloadLanguage = true. Then I think this PR will only contains Spelling corrections and Code style changes.
I think it's better to close this PR and send new with the rest of the changes.

avatar gunjanpatel
gunjanpatel - comment - 15 Jul 2014

I am closing this PR as I didn't found the above issue with staging branch and I send spelling correction in new #3905

avatar gunjanpatel gunjanpatel - close - 15 Jul 2014
avatar gunjanpatel gunjanpatel - head_ref_deleted - 15 Jul 2014

Add a Comment

Login with GitHub to post a comment