User tests: Successful: Unsuccessful:
works like expected
backend please. we have 60+instances of backend and only 3 of back-end.
Thank you @brianteeman for review. I will change it to 'backend'.
I'm not sure what the intend of this PR is. It seems to be related to another PR which isn't merged yet (and maybe never will).
If I understand this right, this doesn't fix a current issue with our core. If that's true, then this one can be closed.
If there is a bug in the other PR, please comment there and get it fixed before it gets merged.
If I'm wrong, please correct me
This is not aimed at another PR, but a codestyle fix for the current codebase. The name of the branch might be misleading. The "big" change is setting the autoloadlanguage flag, which results in the right message being displayed.
@Hackwar The "big" change is setting the autoloadlanguage flag, which results in the right message being displayed.
Yep, but that $autoloadLanguage = true
is currently not needed since we don't use a language string from the plugin. It would load the language file for nothing. It would be needed if we merge the other PR, and thus should be done there.
@gunjanpatel could you update this PR?
Thanks @Hackwar and @Bakual for review. Should I send this PR against staging
instead of master
branch. and I will remove $autoloadLanguage = true
. Then I think this PR will only contains Spelling corrections and Code style changes.
I think it's better to close this PR and send new with the rest of the changes.
Here is a tracker item link http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=31479 for this issue.