[#14768] - [4.0] Move accordion/collapse to JLayouts
- Closed
- 19 Mar 2017
- Medium
- Build: 4.0-dev
- # 14768
- Diff
- C-Lodder:layout2
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
This PR moves the accordion HTML to layouts, allowing people to finally override them.
Testing Instructions
- Apply PR
- Create a new menu item and open the modal "Menu Item Type"
Expected result
The accordion should work the same as before the PR
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Layout Libraries |
@brianteeman if I knew a way...
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14768.
@C-Lodder layouts support sub-layouts https://github.com/joomla/joomla-cms/blob/staging/libraries/cms/layout/file.php#L650
But you'll have to make a B/C break (or not, haven't look the code here TBH)
All JHtml methods can be overridden through the use of its API for defining what method a key should call as demonstrated in https://github.com/mbabker/bs3-demo/blob/master/plg_system_bootstrap3/bootstrap3.php
We should not be having JHtml methods (overridable by API design) be heavily using JLayout. This potentially creates a confusing chain of figuring out what has been overridden (and therefore what's actually in use on the site).
If the intent is to shuffle markup out of JHtml methods, the helpers should be deprecated and JLayout should just be used directly.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-03-19 15:34:48 |
| Closed_By | ⇒ | C-Lodder | |
| Labels |
Added:
?
|
||
I can't say I liked it then either. But not the first time I've been ignored.
layouts that just have closing tags seems massively wrong to me - there must be a better way to do that