[#14750] - Remove from #__extensions useless columns: system_data and custom_data
- Fixed in Code Base
- 19 Mar 2017
- Medium
- Build: 4.0-dev
- # 14750
- Diff
- csthomas:extension_del_columns
User tests: Successful: Unsuccessful:
Pull Request for Issue #14409
Summary of Changes
Remove 2 columns from #__extensions table and all files.
- Fix template copy functionality.
- Fix postgresql installation, some plugins in extension table has missing column value.
- Set correct PK value for template style: protostar in mysql
- Set correct auto increment value for postgresql - copy template error
Testing Instructions
-
Try to copy template style for protostar - before patch it does not work.
-
a. Install dev-4.0 joomla branch and then apply patch and go to database fix button. Mentioned columns should be deleted from databases.
b. Test installation of patched Joomla on mysql and/or postgresql. -
Try to copy template style again - now it should work
Expected result
Template copy works.
Actual result
Error.
Documentation Changes Required
Maybe. Two columns has been deleted from #__extensions table.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | SQL Administration com_admin Postgresql com_joomlaupdate Installation Libraries Unit Tests |
wilsonge
- | Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-03-19 10:46:51 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
?
|
||
As I wrote in the issue, custom_data and system_data aren't useless columns. While they are currently not used by core, the system_data one was used store compatibility informations in J2.5 and probably will be used again in J3 again.
The custom_data one may be used by 3rd parties (eg a module or plugin wants to store something and an own table would be to much overhead).
So imho this PR is a wrong approach to fix a valid issue. We should instead seriously rethink the "NOT NULL" constraint we put on every field. We could save us some trouble by removing that on some of them (and it would fix this issue as well).
If the columns is really needed then we can revert it, but ...
all (or almost all) TEXT/BLOB columns should be NULL DEFAULT NULL.
+1 for revert.
We should make it clear what the field purposes are but just dropping them out of the blue seems a little drastic.
We would have to ask Samuel Moffatt for the real reason they were initially added. It was part of the #__extension table when it was created :)
I am just judging from the name of those fields, and as said I have used one of them in core itself in the past. Imho they are of situational use. We could add some comment to it of course
I have tested this item✅ successfully on eb86c05
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14750.