? Pending

User tests: Successful: Unsuccessful:

avatar tonypartridge
tonypartridge
19 Mar 2017

Pull Request for Issue #6331 .

Summary of Changes

Adds a check if com_categories view and com_banners and if there is a count of items. Then re-maps the images to the intro image for the render to be able to render the image in the list view.

Testing Instructions

Create a tag, e.g. "Red".
Create or edit an article:
Add the previously created tag.
Add an intro image.
Save.
Create or edit a category:
Add the previously created tag.
Add an image (under "options").
Save.
Create a menu item:
Type: Tagged Items
Tag: "Red" (your tag)
Content type: "Article"
Item Options - Item Image: Show (or set this option in the global options).
Create a menu item:
Type: Tagged Items
Tag: "Red" (your tag)
Content type: "Category"
Item Options - Item Image: Show (or set this option in the global options).
Compare both menu item views in frontend. The article one displays the item/intro image, while the category one doesn't display any image.

(above taken from the issue)

Expected result

Shows image in list

Actual result

Shows no image in list.

Documentation Changes Required

avatar tonypartridge tonypartridge - open - 19 Mar 2017
avatar tonypartridge tonypartridge - change - 19 Mar 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 19 Mar 2017
Category com_tags Front End
avatar wilsonge wilsonge - change - 19 Mar 2017
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2017-03-19 10:18:54
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 19 Mar 2017
avatar wilsonge wilsonge - change - 19 Mar 2017
Status Closed New
Closed_Date 2017-03-19 10:18:54
Closed_By wilsonge
avatar wilsonge wilsonge - change - 19 Mar 2017
Status New Pending
avatar wilsonge wilsonge - reopen - 19 Mar 2017
avatar tonypartridge tonypartridge - change - 19 Mar 2017
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2017-03-19 17:32:49
Closed_By tonypartridge
avatar tonypartridge tonypartridge - close - 19 Mar 2017
avatar wilsonge wilsonge - change - 19 Mar 2017
Status Closed New
Closed_Date 2017-03-19 17:32:49
Closed_By tonypartridge
avatar wilsonge wilsonge - change - 19 Mar 2017
Status New Pending
avatar wilsonge wilsonge - reopen - 19 Mar 2017
avatar tonypartridge
tonypartridge - comment - 19 Mar 2017

Also fixed undefined $row call, it should have been $item

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 20 Mar 2017 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 20 Mar 2017

I have tested this item successfully on 03a8457

Using PR Article and Category shows Picture.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14747.

avatar tonypartridge
tonypartridge - comment - 23 Mar 2017

Can we get another test on this please?

avatar tonypartridge
tonypartridge - comment - 24 Mar 2017

@brianteeman could I be so kind to trouble you for a test when you have some spare time.....

avatar brianteeman brianteeman - test_item - 24 Mar 2017 - Tested successfully
avatar brianteeman
brianteeman - comment - 24 Mar 2017

I have tested this item successfully on 2098c07


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14747.

avatar wilsonge wilsonge - close - 24 Mar 2017
avatar wilsonge wilsonge - merge - 24 Mar 2017
avatar wilsonge wilsonge - change - 24 Mar 2017
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-03-24 22:24:53
Closed_By wilsonge
avatar brianteeman
brianteeman - comment - 24 Mar 2017

There you are @tonypartridge wish @wilsonge merged my prs as quickly :)

avatar tonypartridge
tonypartridge - comment - 24 Mar 2017

:D thanks guys! #teamwork #makestheworldgoround

avatar Melvine9
Melvine9 - comment - 20 May 2017

When a tag is create but not use yet ( no result) there is a notice php
Notice: Trying to get property of non-object in C:\wamp\www\components\com_tags\views\tag\view.html.php on line 120

avatar zero-24
zero-24 - comment - 20 May 2017

@Melvine9 please check #16143 thnaks

Add a Comment

Login with GitHub to post a comment