User tests: Successful: Unsuccessful:
Pull Request for Issue #6331 .
Adds a check if com_categories view and com_banners and if there is a count of items. Then re-maps the images to the intro image for the render to be able to render the image in the list view.
Create a tag, e.g. "Red".
Create or edit an article:
Add the previously created tag.
Add an intro image.
Save.
Create or edit a category:
Add the previously created tag.
Add an image (under "options").
Save.
Create a menu item:
Type: Tagged Items
Tag: "Red" (your tag)
Content type: "Article"
Item Options - Item Image: Show (or set this option in the global options).
Create a menu item:
Type: Tagged Items
Tag: "Red" (your tag)
Content type: "Category"
Item Options - Item Image: Show (or set this option in the global options).
Compare both menu item views in frontend. The article one displays the item/intro image, while the category one doesn't display any image.
(above taken from the issue)
Shows image in list
Shows no image in list.
Status | New | ⇒ | Pending |
Category | ⇒ | com_tags Front End |
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-03-19 10:18:54 |
Closed_By | ⇒ | wilsonge | |
Labels |
Added:
?
|
Status | Closed | ⇒ | New |
Closed_Date | 2017-03-19 10:18:54 | ⇒ | |
Closed_By | wilsonge | ⇒ |
Status | New | ⇒ | Pending |
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-03-19 17:32:49 |
Closed_By | ⇒ | tonypartridge |
Status | Closed | ⇒ | New |
Closed_Date | 2017-03-19 17:32:49 | ⇒ | |
Closed_By | tonypartridge | ⇒ |
Status | New | ⇒ | Pending |
I have tested this item
Using PR Article and Category shows Picture.
Can we get another test on this please?
@brianteeman could I be so kind to trouble you for a test when you have some spare time.....
I have tested this item
Status | Pending | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-03-24 22:24:53 |
Closed_By | ⇒ | wilsonge |
There you are @tonypartridge wish @wilsonge merged my prs as quickly :)
:D thanks guys! #teamwork #makestheworldgoround
When a tag is create but not use yet ( no result) there is a notice php
Notice: Trying to get property of non-object in C:\wamp\www\components\com_tags\views\tag\view.html.php on line 120
Also fixed undefined $row call, it should have been $item