? ? ? Pending

User tests: Successful: Unsuccessful:

avatar alikon
alikon
19 Mar 2017

Pull Request for Issue #14573 .

Summary of Changes

fix field group sort order error

Testing Instructions

Open fields and compare the order of the Sort table filters with the order of the columns and they all work

Expected result

no errror

Actual result

A sort filter for Field Group appears at the end of the list and without an Ascending or Descending selector

A sort filter for Field Group also appears in the correct place in the list but again without Ascending or Descending selectors

In addition if you select either of these two selectors you will get an error message

Unknown column 'category_title' in 'order clause'

avatar alikon alikon - open - 19 Mar 2017
avatar alikon alikon - change - 19 Mar 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 19 Mar 2017
Category Administration com_fields Language & Strings
avatar franz-wohlkoenig franz-wohlkoenig - test_item - 19 Mar 2017 - Tested unsuccessfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 19 Mar 2017

I have tested this item 🔴 unsuccessfully on a603795

Field Group ascending and Field Group descending don't sort different Field Groups
Field Group at End of List is shown


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14743.

avatar alikon alikon - change - 19 Mar 2017
Labels Added: ? ?
813d97d 19 Mar 2017 avatar alikon ops
avatar alikon
alikon - comment - 19 Mar 2017

can you retest

Field Group ascending and Field Group descending don't sort different Field Groups

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 19 Mar 2017

bildschirmfoto 2017-03-19 um 09 05 11

avatar alikon
alikon - comment - 19 Mar 2017

sorry i've forgot to push a file
can you retest please 😳

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 19 Mar 2017

fetched Data in Patchtester, same Error is shown.

avatar alikon
alikon - comment - 19 Mar 2017

1 momemt let me recheck

avatar tonypartridge tonypartridge - test_item - 19 Mar 2017 - Tested successfully
avatar tonypartridge
tonypartridge - comment - 19 Mar 2017

I have tested this item successfully on aa6d380


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14743.

avatar alikon
alikon - comment - 19 Mar 2017

@franz-wohlkoenig is ok now

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 19 Mar 2017

@alikon fetched Data in Patchtester, same Error is shown. Reverting PR no Error.

avatar tonypartridge
tonypartridge - comment - 19 Mar 2017

@franz-wohlkoenig did you update your patch tester? It may only be pulling original pull.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 19 Mar 2017

@tonypartridge Patchtester: 1. Reset 2. Fetch Data; clear Browser Cache.

avatar tonypartridge
tonypartridge - comment - 19 Mar 2017

Can you double check you have the latest staging and also please check Database from Extensions -> Database -> fix.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 19 Mar 2017

@tonypartridge All done, same Error.

avatar tonypartridge
tonypartridge - comment - 19 Mar 2017

@franz-wohlkoenig I just re-applied the patch tested it working.

Articles -> Fields -> Sort by Group Ascending && Descending both working fine, same with column clicking.

Can you try a new Joomla! install completely? a clone of the 37 repo staging, and then install the patch tester and test?

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 19 Mar 2017 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 19 Mar 2017

I have tested this item successfully on aa6d380

next Time restart Firefox earlier.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14743.

avatar infograf768
infograf768 - comment - 21 Mar 2017

I have an issue here, although the sorting works:
The small arrow usually displayed in the heading of the columns when sorting is not present.
screen shot 2017-03-21 at 17 06 08
compared to field groups list and other managers where it displays fine:
screen shot 2017-03-21 at 17 08 10

avatar normanmm normanmm - test_item - 24 Mar 2017 - Tested unsuccessfully
avatar normanmm
normanmm - comment - 24 Mar 2017

I have tested this item 🔴 unsuccessfully on aa6d380

Sorting works for all columns , including Field Group ( also if the filter is done applying the filter from the filters list at the right) but no sorting arrows are displayed , for any column.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14743.

avatar brianteeman brianteeman - test_item - 24 Mar 2017 - Tested successfully
avatar brianteeman
brianteeman - comment - 24 Mar 2017

I have tested this item successfully on 7df059b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14743.

avatar alikon
alikon - comment - 24 Mar 2017

fixed the small arrow ↕️

avatar tonypartridge tonypartridge - test_item - 24 Mar 2017 - Tested successfully
avatar tonypartridge
tonypartridge - comment - 24 Mar 2017

I have tested this item successfully on 7df059b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14743.

avatar brianteeman
brianteeman - comment - 24 Mar 2017

RTC?

avatar jeckodevelopment jeckodevelopment - change - 25 Mar 2017
Status Pending Ready to Commit
Labels
avatar jeckodevelopment
jeckodevelopment - comment - 25 Mar 2017

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14743.

avatar rdeutz rdeutz - change - 25 Mar 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-03-25 19:46:03
Closed_By rdeutz
Labels Added: ?
avatar rdeutz rdeutz - close - 25 Mar 2017
avatar rdeutz rdeutz - merge - 25 Mar 2017
avatar Quy
Quy - comment - 25 Mar 2017

No sorting arrow in the Languages column under Fields and Field Groups. Tested with clean install of the latest staging.

avatar infograf768
infograf768 - comment - 29 Mar 2017

@Quy Making PR now

avatar infograf768
infograf768 - comment - 29 Mar 2017

Please test #14983

Add a Comment

Login with GitHub to post a comment