Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#14731] - [4.0] Set min-width for select fields

? Pending

User tests: Successful: Unsuccessful:

avatar ciar4n
ciar4n
18 Mar 2017

Pull Request for Issue # .

Summary of Changes

What it says on the tin

Testing Instructions

Apply patch. Navigate to Article edit -> Options

Before patch

select-width1

After patch

select-width2

Documentation Changes Required

avatar ciar4n ciar4n - open - 18 Mar 2017
avatar ciar4n ciar4n - change - 18 Mar 2017
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 18 Mar 2017
Category ⇒ Administration Templates (admin)
avatar franz-wohlkoenig franz-wohlkoenig - test_item - 18 Mar 2017 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 18 Mar 2017

I have tested this item ✅ successfully on 16f7d80

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14731.

avatar tonypartridge
tonypartridge - comment - 18 Mar 2017

@ciar4n funnily enough I was just thinking about the same. But should we exclude some items. It seems like a lot of wasted space in small items like limits and short valued lists.

screen shot 2017-03-18 at 17 23 57

avatar ciar4n
ciar4n - comment - 19 Mar 2017

@tonypartridge We could do that. It would mean targeting each of these fields individually...

Eg.

select[name="jform[list_limit]"],
select[name="jform[feed_limit]"] {
  min-width: auto;
}
avatar ciar4n
ciar4n - comment - 19 Mar 2017

The SCSS linter doesn't allow the use of IDs so would need to use the name attrib

avatar tonypartridge
tonypartridge - comment - 19 Mar 2017

@wilsonge can we merge this? And if the UX team have anything to say we can look at it more then. But otherwise, this to me improves the native view.

avatar ciar4n ciar4n - change - 19 Mar 2017
Labels Added: ?
avatar wilsonge wilsonge - change - 19 Mar 2017
Status Pending ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2017-03-19 10:52:44
Closed_By ⇒ wilsonge
avatar wilsonge wilsonge - close - 19 Mar 2017
avatar wilsonge wilsonge - merge - 19 Mar 2017

Add a Comment

Login with GitHub to post a comment