? ? Pending

User tests: Successful: Unsuccessful:

avatar wilsonge
wilsonge
18 Mar 2017

Pull Request for part of Issue #14170 .

Summary of Changes

Fixes uninstalling any extension in J4. This is because result is a protected property for the new plugin system meaning the plugin event is missing.

Testing Instructions

Test uninstalling a language

Expected result

It succeeds

Actual result

Too few arguments to function PlgExtensionJoomla::onExtensionAfterUninstall(), 2 passed in /Applications/MAMP/htdocs/joomla_400/libraries/cms/plugin/plugin.php on line 322 and exactly 3 expected

Documentation Changes Required

Document change in property of plugin event.

avatar wilsonge wilsonge - open - 18 Mar 2017
avatar wilsonge wilsonge - change - 18 Mar 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 18 Mar 2017
Category Libraries Front End Plugins
avatar wilsonge wilsonge - close - 18 Mar 2017
avatar wilsonge wilsonge - merge - 18 Mar 2017
avatar wilsonge wilsonge - change - 18 Mar 2017
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-03-18 14:10:20
Closed_By wilsonge
Labels Added: ? ?
avatar mbabker
mbabker - comment - 18 Mar 2017

Could we use a different name for the protected property instead? Seems like reserving that name might be problematic.

avatar wilsonge
wilsonge - comment - 18 Mar 2017

You can use whatever you want. https://github.com/joomla/joomla-cms/blob/4.0-dev/libraries/cms/plugin/plugin.php#L269-L343 method and JApplicationWeb::triggerEvent are the only two things that hard depend on that property name if i recall

avatar mbabker
mbabker - comment - 18 Mar 2017

For core perhaps. But we aren't accounting for third party. And remember all of core is using the app's triggerEvent method for dispatching to make sure the B/C layer is hit.

We're fine ourselves, but we might want to get an idea what types of properties are used in the ecoysystem's events. Maybe "result" isn't used much and we're OK.

Add a Comment

Login with GitHub to post a comment