? Pending

User tests: Successful: Unsuccessful:

avatar joomdonation
joomdonation
18 Mar 2017

Pull Request for Issue # .

Summary of Changes

This PR contains improvement + clean up to view classes to support both namespace and none namespace components in Joomla 4 (backward compatible change). Below are the list of changes/improvements:

  1. Split original View class into AbstractView and HtmlView classes. The purpose is supporting more format like Rss, Json, Csv... in the future.

  2. Introduce two new classes:

  • FormView to handle form add/edit item in the backend. Many repeating/ boring code like getting data, addToolbar can be automatically with this class

  • FormList to handle displaying list of items in the backend. Same with FormView, repeating code is moved into this class so that child class won't have to implement these stuff

See 4.0-dev...joomdonation:view-form-list-demo for the demo if what code can be removed when we use these classes

  1. Supporting namespace component

Since we haven't had a final decision about whether to look for layout an form yet, I still use resources which was agreed on different PR and makes it compatible with namespace com_content PR

Testing intructions

At the moment, this is open for discussion / review only. If it is accepted, I will soon merge my other PRs (Dispatcher, Controller, Model, Views into one PR so that we can have actual human testing)

Documentation Changes Required

avatar joomdonation joomdonation - open - 18 Mar 2017
avatar joomdonation joomdonation - change - 18 Mar 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 18 Mar 2017
Category Libraries
avatar joomdonation joomdonation - change - 18 Mar 2017
The description was changed
avatar joomdonation joomdonation - edited - 18 Mar 2017
avatar joomdonation joomdonation - change - 19 Mar 2017
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2017-03-19 08:17:32
Closed_By joomdonation
Labels Added: ?
avatar joomdonation joomdonation - close - 19 Mar 2017
avatar wilsonge
wilsonge - comment - 20 Mar 2017

Can we keep this one. I'd like to see this one taken forward :)

avatar wilsonge wilsonge - change - 20 Mar 2017
Status Closed New
Closed_Date 2017-03-19 08:17:32
Closed_By joomdonation
avatar wilsonge wilsonge - change - 20 Mar 2017
Status New Pending
avatar wilsonge wilsonge - reopen - 20 Mar 2017
avatar joomdonation
joomdonation - comment - 20 Mar 2017

I closed it because I opened a bigger PR which combine Models, Views, Controllers improvements

Could you please look at the Controllers and Models PRs, too, to see whether (at least the concept is OK) ? I will update the PR to have it works with the new dispatcher implement

d560091 20 Mar 2017 avatar joomdonation CS
avatar joomdonation
joomdonation - comment - 8 Apr 2017

Sorry, I could not solve conflict, so I opened a new PR to replace this one

avatar joomdonation joomdonation - change - 8 Apr 2017
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2017-04-08 09:02:09
Closed_By joomdonation
avatar joomdonation joomdonation - close - 8 Apr 2017
avatar brianteeman
brianteeman - comment - 8 Apr 2017

closed. new pr at #15174

Add a Comment

Login with GitHub to post a comment