User tests: Successful: Unsuccessful:
Pull Request for Issue # .
This PR contains improvement + clean up to view classes to support both namespace and none namespace components in Joomla 4 (backward compatible change). Below are the list of changes/improvements:
Split original View class into AbstractView and HtmlView classes. The purpose is supporting more format like Rss, Json, Csv... in the future.
Introduce two new classes:
FormView to handle form add/edit item in the backend. Many repeating/ boring code like getting data, addToolbar can be automatically with this class
FormList to handle displaying list of items in the backend. Same with FormView, repeating code is moved into this class so that child class won't have to implement these stuff
See 4.0-dev...joomdonation:view-form-list-demo for the demo if what code can be removed when we use these classes
Since we haven't had a final decision about whether to look for layout an form yet, I still use resources which was agreed on different PR and makes it compatible with namespace com_content PR
At the moment, this is open for discussion / review only. If it is accepted, I will soon merge my other PRs (Dispatcher, Controller, Model, Views into one PR so that we can have actual human testing)
Status | New | ⇒ | Pending |
Category | ⇒ | Libraries |
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-03-19 08:17:32 |
Closed_By | ⇒ | joomdonation | |
Labels |
Added:
?
|
Status | Closed | ⇒ | New |
Closed_Date | 2017-03-19 08:17:32 | ⇒ | |
Closed_By | joomdonation | ⇒ |
Status | New | ⇒ | Pending |
I closed it because I opened a bigger PR which combine Models, Views, Controllers improvements
Could you please look at the Controllers and Models PRs, too, to see whether (at least the concept is OK) ? I will update the PR to have it works with the new dispatcher implement
Sorry, I could not solve conflict, so I opened a new PR to replace this one
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-04-08 09:02:09 |
Closed_By | ⇒ | joomdonation |
Can we keep this one. I'd like to see this one taken forward :)