? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
17 Mar 2017

In com_templates if you select a zip file you will see a preview as shown in the screenshot below

For accessibility we need to add the aria-hidden tag to the icon

screenshotr19-54-30

avatar brianteeman brianteeman - open - 17 Mar 2017
avatar brianteeman brianteeman - change - 17 Mar 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 17 Mar 2017
Category Administration com_templates Templates (admin)
avatar RonakParmar
RonakParmar - comment - 23 Mar 2017

To test this PR I have added a zip file in hathor template folder and selected that zip file in hathor template file list at administrator side. (Please see attached screen short). I got fatal error " Fatal error: Class 'ZipArchive' not found in joomlacmsstaging/administrator/components/com_templates/models/template.php on line 1306".
Am I doing anything wrong to test this PR? Please correct me.

Joomla! 3.7.0-rc1 dev [ Amani ] 21-February-2017 15:03 GMT
PHP Version 5.6.30-7+deb.sury.org~precise+1

screen shot 2017-03-23 at 07 23 49screen shot 2017-03-23 at 07 23 50


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14706.

avatar mbabker
mbabker - comment - 23 Mar 2017

Your system doesn't have PHP's zip extension installed and/or enabled.

avatar RonakParmar RonakParmar - test_item - 24 Mar 2017 - Tested successfully
avatar RonakParmar
RonakParmar - comment - 24 Mar 2017

I have tested this item successfully on fc567bd


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14706.

avatar alikon alikon - test_item - 28 Mar 2017 - Tested successfully
avatar alikon
alikon - comment - 28 Mar 2017

I have tested this item successfully on fc567bd


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14706.

avatar jeckodevelopment jeckodevelopment - change - 28 Mar 2017
Status Pending Ready to Commit
avatar jeckodevelopment
jeckodevelopment - comment - 28 Mar 2017

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14706.

avatar zero-24 zero-24 - change - 29 Mar 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-03-29 11:10:09
Closed_By zero-24
Labels Added: ? ?
avatar zero-24 zero-24 - close - 29 Mar 2017
avatar zero-24 zero-24 - merge - 29 Mar 2017
avatar zero-24
zero-24 - comment - 29 Mar 2017

Thanks 👍

avatar brianteeman
brianteeman - comment - 29 Mar 2017

Thanks for testing and mergin

Add a Comment

Login with GitHub to post a comment