? ? Pending

User tests: Successful: 0 Unsuccessful: 0

avatar brianteeman
brianteeman
17 Mar 2017

When reading our default markup for rendering icons, assisistive technology may have the following problems.

The assistive technology will not find any content to read out to a user
The assistive technology will read the unicode equivalent, which does not match up to what the icon means in context, or worse is just plain confusing. In our use case it is always plain wrong. For example the unicode character used to display the trashed icon is \4c which is equal to L

When an icon is not an interactive element the simplest way to provide a text alternative is to use the aria-hidden="true" attribute on the icon and to include the text with an additional element, such as a < span>, with appropriate CSS to visually hide the element while keeping it accessible to assistive technologies.

In this case we have the text and it is displayed so we just need to add the aria-hidden to prevent the icon being "read aloud"

This PR addresses the use case shown in the images below

screenshotr15-46-21

screenshotr15-46-30

screenshotr15-48-05

avatar brianteeman brianteeman - open - 17 Mar 2017
avatar brianteeman brianteeman - change - 17 Mar 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 17 Mar 2017
Category Administration com_content com_contenthistory
avatar Quy
Quy - comment - 23 Mar 2017

Missed this one <span class="icon-featured"></span>&nbsp;.

avatar brianteeman brianteeman - change - 23 Mar 2017
Labels Added: ?
2f1b80d 23 Mar 2017 avatar brianteeman oops
avatar Quy Quy - test_item - 23 Mar 2017 - Tested successfully
avatar Quy
Quy - comment - 23 Mar 2017

I have tested this item successfully on 2f1b80d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14698.

avatar alikon alikon - test_item - 28 Mar 2017 - Tested successfully
avatar alikon
alikon - comment - 28 Mar 2017

I have tested this item successfully on 2f1b80d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14698.

avatar jeckodevelopment jeckodevelopment - change - 28 Mar 2017
Status Pending Ready to Commit
avatar jeckodevelopment
jeckodevelopment - comment - 28 Mar 2017

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14698.

avatar zero-24 zero-24 - change - 29 Mar 2017
Labels Added: ?
avatar rdeutz rdeutz - change - 30 Mar 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-03-30 21:33:42
Closed_By rdeutz
avatar rdeutz rdeutz - close - 30 Mar 2017
avatar rdeutz rdeutz - merge - 30 Mar 2017
avatar brianteeman
brianteeman - comment - 30 Mar 2017

thanks

Add a Comment

Login with GitHub to post a comment