? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
17 Mar 2017

When reading our default markup for rendering icons, assisistive technology may have the following problems.

The assistive technology will not find any content to read out to a user
The assistive technology will read the unicode equivalent, which does not match up to what the icon means in context, or worse is just plain confusing. In our use case it is always plain wrong. For example the unicode character used to display the trashed icon is \4c which is equal to L

When an icon is not an interactive element the simplest way to provide a text alternative is to use the aria-hidden="true" attribute on the icon and to include the text with an additional element, such as a < span>, with appropriate CSS to visually hide the element while keeping it accessible to assistive technologies.

In this case we have the text and it is displayed so we just need to add the aria-hidden to prevent the icon being "read aloud"

This PR addresses the use cases shown in the image below

screenshotr15-18-22

screenshotr15-21-21

avatar brianteeman brianteeman - open - 17 Mar 2017
avatar brianteeman brianteeman - change - 17 Mar 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 17 Mar 2017
Category Administration com_menus Front End com_finder
avatar laoneo laoneo - test_item - 20 Mar 2017 - Not tested
avatar laoneo
laoneo - comment - 20 Mar 2017

I have not tested this item.

Didn't test it with an accessibility reader, but according to the docs its the right way.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14694.

avatar Quy Quy - test_item - 30 Mar 2017 - Tested successfully
avatar Quy
Quy - comment - 30 Mar 2017

I have tested this item successfully on eb6a307

Code review.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14694.

avatar alikon alikon - test_item - 31 Mar 2017 - Tested successfully
avatar alikon
alikon - comment - 31 Mar 2017

I have tested this item successfully on eb6a307


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14694.

avatar franz-wohlkoenig franz-wohlkoenig - change - 31 Mar 2017
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 31 Mar 2017

RTC after two successful testes.

avatar rdeutz rdeutz - change - 31 Mar 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-03-31 07:38:14
Closed_By rdeutz
Labels Added: ?
avatar rdeutz rdeutz - close - 31 Mar 2017
avatar rdeutz rdeutz - merge - 31 Mar 2017

Add a Comment

Login with GitHub to post a comment