[#14687] - A11y icons table headers with no text
- Fixed in Code Base
- 29 Mar 2017
- Medium
- Build: staging
- # 14687
- Diff
- brianteeman:a11y_icons
User tests: Successful: Unsuccessful:
When reading our default markup for rendering icons, assisistive technology may have the following problems.
The assistive technology will not find any content to read out to a user
The assistive technology will read the unicode equivalent, which does not match up to what the icon means in context, or worse is just plain confusing. In our use case it is always plain wrong. For example the unicode character used to display the trashed icon is \4c which is equal to L
When an icon is not an interactive element the simplest way to provide a text alternative is to use the aria-hidden="true" attribute on the icon and to include the text with an additional element, such as a < span>, with appropriate CSS to visually hide the element while keeping it accessible to assistive technologies.
This PR addresses this issue in all the places in the admin that we have an icon only as a table header
com_categories, com_banners (clients), com_tags
Thanks to @fuzzbomb for his guidance on this - there is more to come
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_banners com_categories com_tags Templates (admin) |
| Title |
|
||||||
| Title |
|
||||||
Thanks @fuzzbomb I am gradually working through it all in batches so it's
easier to test
On 17 Mar 2017 9:03 p.m., "Andrew Macpherson" notifications@github.com
wrote:
Looks good. This is just a note to confirm this is the approach I outlined
to @brianteeman https://github.com/brianteeman in the pub last night.
Glad I could help out another open-source project!—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#14687 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8UFspPxd_ptl68gRW1FsQV6LdaLHks5rmvUvgaJpZM4MgmaN
.
| Labels |
Added:
?
|
||
I have tested this item
Didn't test it with an accessibility reader, but according to the docs its the right way. Will also adapt my extensions now.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14687.
I tested this with NVDA and Orca but I suppose that both screen readers are not able to cope with aria-hidden. Is there a free screen reader that actually can handle this properly? Otherwise from reading the documentation everthing looks ok.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14687.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14687.
Thanks for submitting and testing!
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-03-29 11:07:46 |
| Closed_By | ⇒ | zero-24 | |
| Labels |
Added:
?
|
||
Thanks for merging
Looks good. This is just a note to confirm this is the approach I outlined to @brianteeman in the pub last night. Glad I could help out another open-source project!