[#14681] - [com_fields] Update the values correctly on save field
- Fixed in Code Base
- 23 Mar 2017
- Medium
- Build: staging
- # 14681
- Diff
- Digital-Peak:cf/delete-options
User tests: Successful: Unsuccessful:
Pull Request for Issue #14589.
Summary of Changes
When the options did change of a list, radio or checkbox field then it didn't work correctly since the move to subformfields in #13069.
Testing Instructions
- Create a checkbox field with multiple options.
- Edit an article and select some of the options.
- Go back to the field and delete an option you have selected in the article.
- Create a new option.
- Save the field.
Expected result
The article has still the options selected which are not touched and the option is unselected.
Actual result
An error is thrown as in #14589.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_fields |
| Labels |
Added:
?
|
||
@Quy can you retest again, changes some code.
@franz-wohlkoenig let first test @Quy again, then it will be ready for testing.
It works except when the value contains a single quote.
You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 's')' at line 3
Thanks for the report, it should be fixed now. Can you retest?
@franz-wohlkoenig it is open for testing now.
I have tested this item
With- and without PR:
- 3 Options, all selected in Article
- 1 Option deleted, 1 new Option appended
In Article 2 Options are selected, the new Option isn't selected.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14681.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14681.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14681.
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-03-23 20:56:34 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
|
||
@laoneo is this PR ready for Test?